From: David Miller <davem@davemloft.net>
To: linmiaohe@huawei.com
Cc: kuba@kernel.org, fw@strlen.de, pshelar@ovn.org,
martin.varghese@nokia.com, pabeni@redhat.com,
edumazet@google.com, dcaratti@redhat.com,
steffen.klassert@secunet.com, shmulik@metanetworks.com,
kyk.segfault@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Use __skb_pagelen() directly in skb_cow_data()
Date: Mon, 03 Aug 2020 15:38:55 -0700 (PDT) [thread overview]
Message-ID: <20200803.153855.1717799017490441577.davem@davemloft.net> (raw)
In-Reply-To: <1596274223-24555-1-git-send-email-linmiaohe@huawei.com>
From: linmiaohe <linmiaohe@huawei.com>
Date: Sat, 1 Aug 2020 17:30:23 +0800
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> In fact, skb_pagelen() - skb_headlen() is equal to __skb_pagelen(), use it
> directly to avoid unnecessary skb_headlen() call.
>
> Also fix the CHECK note of checkpatch.pl:
> Comparison to NULL could be written "!__pskb_pull_tail"
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Applied.
prev parent reply other threads:[~2020-08-03 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 9:30 [PATCH] net: Use __skb_pagelen() directly in skb_cow_data() linmiaohe
2020-08-03 22:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803.153855.1717799017490441577.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=kyk.segfault@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=shmulik@metanetworks.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).