Re: [PATCH net-next 0/9] mlxsw: Add support for buffer drop traps

[David Miller <davem@davemloft.net>]

From: Ido Schimmel <idosch@idosch.org>
Date: Mon,  3 Aug 2020 19:11:32 +0300

> From: Ido Schimmel <idosch@mellanox.com>
> 
> Petr says:
> 
> A recent patch set added the ability to mirror buffer related drops
> (e.g., early drops) through a netdev. This patch set adds the ability to
> trap such packets to the local CPU for analysis.
> 
> The trapping towards the CPU is configured by using tc-trap action
> instead of tc-mirred as was done when the packets were mirrored through
> a netdev. A future patch set will also add the ability to sample the
> dropped packets using tc-sample action.
> 
> The buffer related drop traps are added to devlink, which means that the
> dropped packets can be reported to user space via the kernel's
> drop_monitor module.
> 
> Patch set overview:
> 
> Patch #1 adds the early_drop trap to devlink
> 
> Patch #2 adds extack to a few devlink operations to facilitate better
> error reporting to user space. This is necessary - among other things -
> because the action of buffer drop traps cannot be changed in mlxsw
> 
> Patch #3 performs a small refactoring in mlxsw, patch #4 fixes a bug that
> this patchset would trigger.
> 
> Patches #5-#6 add the infrastructure required to support different traps
> / trap groups in mlxsw per-ASIC. This is required because buffer drop
> traps are not supported by Spectrum-1
> 
> Patch #7 extends mlxsw to register the early_drop trap
> 
> Patch #8 adds the offload logic for the "trap" action at a qevent block.
> 
> Patch #9 adds a mlxsw-specific selftest.

Series applied, thank you.