From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Roi Dayan <roid@mellanox.com>
Cc: netdev@vger.kernel.org, Paul Blakey <paulb@mellanox.com>,
Oz Shlomo <ozsh@mellanox.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>
Subject: Re: [PATCH net v2 0/2] netfilter: conntrack: Fix CT offload timeout on heavily loaded systems
Date: Mon, 3 Aug 2020 12:33:39 +0200 [thread overview]
Message-ID: <20200803103339.GA2903@salvia> (raw)
In-Reply-To: <20200803073305.702079-1-roid@mellanox.com>
On Mon, Aug 03, 2020 at 10:33:03AM +0300, Roi Dayan wrote:
> On heavily loaded systems the GC can take time to go over all existing
> conns and reset their timeout. At that time other calls like from
> nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as
> expired. To fix this when we set the offload bit we should also reset
> the timeout instead of counting on GC to finish first iteration over
> all conns before the initial timeout.
>
> First commit is to expose the function that updates the timeout.
> Second commit is to use it from flow_offload_add().
Series applied to nf.git, thanks.
prev parent reply other threads:[~2020-08-03 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 7:33 [PATCH net v2 0/2] netfilter: conntrack: Fix CT offload timeout on heavily loaded systems Roi Dayan
2020-08-03 7:33 ` [PATCH net v2 1/2] netfilter: conntrack: Move nf_ct_offload_timeout to header file Roi Dayan
2020-08-03 11:03 ` Pablo Neira Ayuso
2020-08-03 13:15 ` Roi Dayan
2020-08-03 7:33 ` [PATCH net v2 2/2] netfilter: flowtable: Set offload timeout when adding flow Roi Dayan
2020-08-03 10:33 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803103339.GA2903@salvia \
--to=pablo@netfilter.org \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).