From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC68C433E0 for ; Mon, 3 Aug 2020 13:31:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 922392076C for ; Mon, 3 Aug 2020 13:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbgHCNb1 (ORCPT ); Mon, 3 Aug 2020 09:31:27 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40220 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgHCNb1 (ORCPT ); Mon, 3 Aug 2020 09:31:27 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k2aYn-0082pS-TP; Mon, 03 Aug 2020 15:31:25 +0200 Date: Mon, 3 Aug 2020 15:31:25 +0200 From: Andrew Lunn To: Michal Kubecek Cc: netdev@vger.kernel.org Subject: Re: [PATCH ethtool 0/7] compiler warnings cleanup, part 1 Message-ID: <20200803133125.GN1862409@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 03, 2020 at 01:57:03PM +0200, Michal Kubecek wrote: > Maciej Żenczykowski recently cleaned up many "unused parameter" compiler > warnings but some new occurences appeared since (mostly in netlink code). Hi Michal Could you modify the compiler flags to get gcc to warn about these? Otherwise they will just come back again. Andrew