From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next v2 2/5] devlink: introduce flash update overwrite mask
Date: Mon, 3 Aug 2020 17:38:30 +0200 [thread overview]
Message-ID: <20200803153830.GD2290@nanopsycho> (raw)
In-Reply-To: <20200801002159.3300425-3-jacob.e.keller@intel.com>
Sat, Aug 01, 2020 at 02:21:56AM CEST, jacob.e.keller@intel.com wrote:
[...]
>+ nla_mask = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK];
>+ if (nla_mask) {
>+ if (!(supported_params & DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK)) {
>+ NL_SET_ERR_MSG_ATTR(info->extack, nla_mask,
>+ "overwrite is not supported");
>+ return -EOPNOTSUPP;
>+ }
>+ params.overwrite_mask = nla_get_u32(nla_mask);
It's a bitfield, should be NL_ATTR_TYPE_BITFIELD32.
next prev parent reply other threads:[~2020-08-03 15:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 0:21 [net-next v2 0/5] devlink flash update overwrite mask Jacob Keller
2020-08-01 0:21 ` [net-next v2 1/5] devlink: convert flash_update to use params structure Jacob Keller
2020-08-03 15:46 ` Jiri Pirko
2020-08-01 0:21 ` [net-next v2 2/5] devlink: introduce flash update overwrite mask Jacob Keller
2020-08-03 15:38 ` Jiri Pirko [this message]
2020-08-03 16:53 ` Jacob Keller
2020-08-03 23:08 ` Jacob Keller
2020-08-01 0:21 ` [net-next v2 3/5] ice: add support for " Jacob Keller
2020-08-01 0:21 ` [iproute2-next v2 4/5] Update devlink header for overwrite mask attribute Jacob Keller
2020-08-01 0:21 ` [iproute2-next v2 5/5] devlink: support setting the overwrite mask Jacob Keller
2020-08-03 15:53 ` David Ahern
2020-08-03 16:20 ` Jiri Pirko
2020-08-03 16:56 ` Jacob Keller
2020-08-03 21:20 ` David Ahern
2020-08-03 22:44 ` Jacob Keller
2020-08-03 23:30 ` Jacob Keller
2020-08-03 23:54 ` David Ahern
2020-08-04 18:31 ` Jacob Keller
2020-08-03 15:28 ` [net-next v2 0/5] devlink flash update " Jiri Pirko
2020-08-03 16:51 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803153830.GD2290@nanopsycho \
--to=jiri@resnulli.us \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).