From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Madalin Bucur (OSS)" <madalin.bucur@oss.nxp.com>,
Vikas Singh <vikas.singh@puresoftware.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Calvin Johnson (OSS)" <calvin.johnson@oss.nxp.com>,
kuldip dwivedi <kuldip.dwivedi@puresoftware.com>,
Vikas Singh <vikas.singh@nxp.com>
Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY
Date: Mon, 3 Aug 2020 17:59:00 +0100 [thread overview]
Message-ID: <20200803165900.GQ1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200803150051.GA1919070@lunn.ch>
On Mon, Aug 03, 2020 at 05:00:51PM +0200, Andrew Lunn wrote:
> On Mon, Aug 03, 2020 at 02:33:56PM +0000, Madalin Bucur (OSS) wrote:
> > > -----Original Message-----
> > > From: Andrew Lunn <andrew@lunn.ch>
> > > Sent: 03 August 2020 15:58
> > > To: Madalin Bucur (OSS) <madalin.bucur@oss.nxp.com>
> > > Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>; Vikas Singh
> > > <vikas.singh@puresoftware.com>; f.fainelli@gmail.com; hkallweit1@gmail.com;
> > > netdev@vger.kernel.org; Calvin Johnson (OSS) <calvin.johnson@oss.nxp.com>;
> > > kuldip dwivedi <kuldip.dwivedi@puresoftware.com>; Vikas Singh
> > > <vikas.singh@nxp.com>
> > > Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY
> > >
> > > > I see you agree that there were and there will be many changes for a
> > > while,
> > > > It's not a complaint, I know hot it works, it's just a decision based on
> > > > required effort vs features offered vs user requirements. Lately it's
> > > been
> > > > time consuming to try to fix things in this area.
> > >
> > > So the conclusion to all this that you are unwilling to use the
> > > correct API for this, which would be phylink, and the SFP code. So:
> > >
> > > NACK
> > >
> > > Andrew
> >
> > You've rejected a generic change - ACPI support for fixed link.
> > The discussion above is just an example of how it could have been (mis-)used.
> > Are you rejecting the general case or just the particular one?
>
> So far, nobody has corrected me that the MAC is not connected to an
> SFP socket. So i see two sorts of abuse going on here:
>
> 1) Using a fixed link with a hack to allow 10G. phylink allows 10G
> fixed links without an hacks.
>
> 2) Using a fixed link when not even appropriate since phylink should
> be used to control the SFP.
>
> Now, you can do whatever you want in your Vendor Crap tree. But there
> is no reason mainline should help you support your vendor crap tree.
+1 for everything above.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-08-03 16:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:13 [PATCH 0/2] Add fwnode helper functions to MDIO bus driver Vikas Singh
2020-07-28 12:13 ` [PATCH 1/2] net: phy: Add fwnode helper functions Vikas Singh
2020-08-01 8:10 ` kernel test robot
2020-07-28 12:13 ` [PATCH 2/2] net: phy: Associate device node with fixed PHY Vikas Singh
2020-07-28 13:00 ` Andrew Lunn
[not found] ` <CADvVLtXVVfU3-U8DYPtDnvGoEK2TOXhpuE=1vz6nnXaFBA8pNA@mail.gmail.com>
2020-07-31 15:31 ` Andrew Lunn
[not found] ` <CADvVLtUrZDGqwEPO_ApCWK1dELkUEjrH47s1CbYEYOH9XgZMRg@mail.gmail.com>
2020-08-01 9:41 ` Russell King - ARM Linux admin
2020-08-01 15:11 ` Andrew Lunn
2020-08-03 8:33 ` Madalin Bucur (OSS)
2020-08-03 9:07 ` Russell King - ARM Linux admin
2020-08-03 11:45 ` Madalin Bucur (OSS)
2020-08-03 12:57 ` Andrew Lunn
2020-08-03 14:33 ` Madalin Bucur (OSS)
2020-08-03 15:00 ` Andrew Lunn
2020-08-03 16:59 ` Russell King - ARM Linux admin [this message]
2020-08-03 14:10 ` Russell King - ARM Linux admin
2020-08-03 14:47 ` Madalin Bucur (OSS)
2020-08-03 16:53 ` Russell King - ARM Linux admin
2020-08-04 5:36 ` Madalin Bucur (OSS)
-- strict thread matches above, loose matches on Subject: below --
2020-07-22 11:32 [PATCH 0/2] Add fwnode helper functions to MDIO bus driver Vikas Singh
2020-07-22 11:32 ` [PATCH 2/2] net: phy: Associate device node with fixed PHY Vikas Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803165900.GQ1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=vikas.singh@nxp.com \
--cc=vikas.singh@puresoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).