netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH ethtool 2/7] cable_test: clean up unused parameters
Date: Tue, 4 Aug 2020 01:59:27 +0200	[thread overview]
Message-ID: <20200803235927.GO1862409@lunn.ch> (raw)
In-Reply-To: <4e6a60bf95b819912eb08cb13276791d8ec9feac.1596451857.git.mkubecek@suse.cz>

On Mon, Aug 03, 2020 at 01:57:09PM +0200, Michal Kubecek wrote:
> Functions nl_cable_test_ntf_attr() and nl_cable_test_tdr_ntf_attr() do not
> use nlctx parameter and as they are not callbacks with fixed signature, we
> can simply drop it. Once we do, the same is true for cable_test_ntf_nest()
> and cable_test_tdr_ntf_nest().
> 
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2020-08-03 23:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 11:57 [PATCH ethtool 0/7] compiler warnings cleanup, part 1 Michal Kubecek
2020-08-03 11:57 ` [PATCH ethtool 1/7] rename maybe_unused macro to __maybe_unused Michal Kubecek
2020-08-03 11:57 ` [PATCH ethtool 2/7] cable_test: clean up unused parameters Michal Kubecek
2020-08-03 23:59   ` Andrew Lunn [this message]
2020-08-03 11:57 ` [PATCH ethtool 3/7] igc: mark unused callback parameter Michal Kubecek
2020-08-03 11:57 ` [PATCH ethtool 4/7] netlink: " Michal Kubecek
2020-08-03 11:57 ` [PATCH ethtool 5/7] netlink: mark unused parameters of bitset walker callbacks Michal Kubecek
2020-08-03 11:57 ` [PATCH ethtool 6/7] netlink: mark unused parameters of parser callbacks Michal Kubecek
2020-08-03 11:57 ` [PATCH ethtool 7/7] ioctl: avoid zero length array warning in get_stringset() Michal Kubecek
2020-08-03 13:31 ` [PATCH ethtool 0/7] compiler warnings cleanup, part 1 Andrew Lunn
2020-08-03 13:53   ` Michal Kubecek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803235927.GO1862409@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).