From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB76C433E0 for ; Tue, 4 Aug 2020 07:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F2022086A for ; Tue, 4 Aug 2020 07:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eZj6zjVP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729663AbgHDHrH (ORCPT ); Tue, 4 Aug 2020 03:47:07 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34348 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727116AbgHDHrH (ORCPT ); Tue, 4 Aug 2020 03:47:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596527226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cg9TD9KR6aQ8DCDj8rct6KumwH28jaxmuwePKYiLJXw=; b=eZj6zjVPGBIKvtc0lc8BCCkeCxzxc5pi3jTSsJ/zbeRAO/gA9cs641ZXpgKmKg59U/Zt/F k3N4GElqn92uNYU17IzzA5zWVRFg3bbfSil/bllZNzG3rQajVjfM8mGjc4zyDi0TTWD/b2 sq88/cxYYbxbiBY4IXv2KaUJ+bsuTc0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-jp17yQjhM9quOnKufKCYyw-1; Tue, 04 Aug 2020 03:47:04 -0400 X-MC-Unique: jp17yQjhM9quOnKufKCYyw-1 Received: by mail-wr1-f70.google.com with SMTP id t3so11298227wrr.5 for ; Tue, 04 Aug 2020 00:47:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cg9TD9KR6aQ8DCDj8rct6KumwH28jaxmuwePKYiLJXw=; b=XowHUXmnoCjHrPhkS+8ybbU30/ldYiC52qi0e0qcQsC02nkhfu1Q8FQTRFonPhFn4g 68Jh3XQZnrBN3wUxDISWEJCWmM6xI+q1MKAZAv0afin5Ou1KELurRteqZqc/7QbXje4F WlkkS6pVWdkHGVqs8LE/fq/ab1dt9Qr+bugY4vJFufmsaHYKl+KfzspBOF99JLdMy/Nn jXwcAdumDhY1PlWr0RCzI2De4BUJMriRHZiGVlNW/xBwJRM2nT4LRAxSM5VcDYzmQhuS txQHXZyFVESqoZLCZdvGLLmzzWLKGy5xcWjKkbnj+iT50M+bvjeSlPhj0ygx7Cfxmd4x lrLA== X-Gm-Message-State: AOAM530C47IauuCKz5zj8MUjIUHdbicg//sZBg6lGo9guHRJN94i02gq 7UHHjKNOuNq8/L7HFH4omUNwmZ19Vbo80EyddX5NSQLnCVq0siln5nDPxp2ioG0u5ukT9d13t42 OeQiV1kINdk45EJkZ X-Received: by 2002:adf:bbca:: with SMTP id z10mr17609775wrg.425.1596527223359; Tue, 04 Aug 2020 00:47:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPjz5bwTC3Diibtx3CA+YLdF8jlrDG6oiEBzVV7ZwSBS5VL29gytQGv8qz1KPtfL41oeE0bg== X-Received: by 2002:adf:bbca:: with SMTP id z10mr17609757wrg.425.1596527223080; Tue, 04 Aug 2020 00:47:03 -0700 (PDT) Received: from linux.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id p3sm3303297wma.44.2020.08.04.00.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 00:47:02 -0700 (PDT) Date: Tue, 4 Aug 2020 09:47:00 +0200 From: Guillaume Nault To: Hangbin Liu Cc: netdev@vger.kernel.org, Petr Machata , "David S . Miller" , Roopa Prabhu , David Ahern , Andreas Karis , stable@vger.kernel.org Subject: Re: [PATCHv2 net 0/2] Add IP_DSCP_MASK and fix vxlan tos value before xmit Message-ID: <20200804074700.GA3798@linux.home> References: <20200803080217.391850-1-liuhangbin@gmail.com> <20200804014312.549760-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804014312.549760-1-liuhangbin@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 04, 2020 at 09:43:10AM +0800, Hangbin Liu wrote: > This patch set is aim to update the old IP_TOS_MASK to new IP_DSCP_MASK > as tos value has been obsoleted for a long time. But to make sure we don't > break any existing behaviour, we can't just replease all IP_TOS_MASK > to new IP_DSCP_MASK. > > So let's update it case by case. The first issue we will fix is that vxlan > is unable to take the first 3 bits from DSCP field before xmit. Use the > new RT_DSCP() would resolve this. > > v2: Remove IP_DSCP() definition as it's duplicated with RT_DSCP(). > Post the patch to net instead of net-next as we need fix the vxlan issue Acked-by: Guillaume Nault