From: Michal Kubecek <mkubecek@suse.cz>
To: Roi Dayan <roid@mellanox.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH ethtool] ethtool.spec: Add bash completion script
Date: Tue, 4 Aug 2020 15:12:16 +0200 [thread overview]
Message-ID: <20200804131216.gn6qgwvniulsqjzd@lion.mk-sys.cz> (raw)
In-Reply-To: <20200803132338.221961-1-roid@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Mon, Aug 03, 2020 at 04:23:38PM +0300, Roi Dayan wrote:
> After the additon of the bash completion script, packaging
> using the default spec file fails for installed but not packaged
> error. so package it.
>
> Fixes: 9b802643d7bd ("ethtool: Add bash-completion script")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
Applied, thank you. We are using a heavily modified specfile in openSUSE
so I never noticed. Added rpmbuild to my check script now.
Michal
> ---
> ethtool.spec.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ethtool.spec.in b/ethtool.spec.in
> index 9c01b07abf2b..75f9be6aafa6 100644
> --- a/ethtool.spec.in
> +++ b/ethtool.spec.in
> @@ -34,6 +34,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
> %defattr(-,root,root)
> %{_sbindir}/ethtool
> %{_mandir}/man8/ethtool.8*
> +%{_datadir}/bash-completion/completions/ethtool
> %doc AUTHORS COPYING NEWS README
>
>
> --
> 2.8.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-08-04 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 13:23 [PATCH ethtool] ethtool.spec: Add bash completion script Roi Dayan
2020-08-04 13:12 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804131216.gn6qgwvniulsqjzd@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=roid@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).