From: Guillaume Nault <gnault@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Petr Machata <pmachata@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
David Ahern <dsahern@kernel.org>,
Andreas Karis <akaris@redhat.com>
Subject: Re: [PATCH net] Revert "vxlan: fix tos value before xmit"
Date: Wed, 5 Aug 2020 10:44:27 +0200 [thread overview]
Message-ID: <20200805084427.GC11547@pc-2.home> (raw)
In-Reply-To: <20200805024131.2091206-1-liuhangbin@gmail.com>
On Wed, Aug 05, 2020 at 10:41:31AM +0800, Hangbin Liu wrote:
> This reverts commit 71130f29979c7c7956b040673e6b9d5643003176.
>
> In commit 71130f29979c ("vxlan: fix tos value before xmit") we want to
> make sure the tos value are filtered by RT_TOS() based on RFC1349.
>
> 0 1 2 3 4 5 6 7
> +-----+-----+-----+-----+-----+-----+-----+-----+
> | PRECEDENCE | TOS | MBZ |
> +-----+-----+-----+-----+-----+-----+-----+-----+
>
> But RFC1349 has been obsoleted by RFC2474. The new DSCP field defined like
>
> 0 1 2 3 4 5 6 7
> +-----+-----+-----+-----+-----+-----+-----+-----+
> | DS FIELD, DSCP | ECN FIELD |
> +-----+-----+-----+-----+-----+-----+-----+-----+
>
> So with
>
> IPTOS_TOS_MASK 0x1E
> RT_TOS(tos) ((tos)&IPTOS_TOS_MASK)
>
> the first 3 bits DSCP info will get lost.
>
> To take all the DSCP info in xmit, we should revert the patch and just push
> all tos bits to ip_tunnel_ecn_encap(), which will handling ECN field later.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
I guess an explicit
Fixes: 71130f29979c ("vxlan: fix tos value before xmit").
tag would help the -stable maintainers.
Apart from that,
Acked-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2020-08-05 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 2:41 [PATCH net] Revert "vxlan: fix tos value before xmit" Hangbin Liu
2020-08-05 8:44 ` Guillaume Nault [this message]
2020-08-05 10:18 ` Hangbin Liu
2020-08-05 19:11 ` David Miller
2020-08-06 2:52 ` Hangbin Liu
2020-08-12 0:02 ` David Miller
2020-08-12 2:28 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805084427.GC11547@pc-2.home \
--to=gnault@redhat.com \
--cc=akaris@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pmachata@gmail.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).