From: David Miller <davem@davemloft.net>
To: thierry.reding@gmail.com
Cc: kuba@kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-tegra@vger.kernel.org,
ejh@nvidia.com
Subject: Re: [PATCH net] r8152: Use MAC address from correct device tree node
Date: Sat, 08 Aug 2020 14:27:38 -0700 (PDT) [thread overview]
Message-ID: <20200808.142738.431277384120054736.davem@davemloft.net> (raw)
In-Reply-To: <20200807073632.63057-1-thierry.reding@gmail.com>
From: Thierry Reding <thierry.reding@gmail.com>
Date: Fri, 7 Aug 2020 09:36:32 +0200
> From: Thierry Reding <treding@nvidia.com>
>
> Query the USB device's device tree node when looking for a MAC address.
> The struct device embedded into the struct net_device does not have a
> device tree node attached at all.
>
> The reason why this went unnoticed is because the system where this was
> tested was one of the few development units that had its OTP programmed,
> as opposed to production systems where the MAC address is stored in a
> separate EEPROM and is passed via device tree by the firmware.
>
> Reported-by: EJ Hsu <ejh@nvidia.com>
> Fixes: acb6d3771a03 ("r8152: Use MAC address from device tree if available")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Applied, thank you.
prev parent reply other threads:[~2020-08-08 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 7:36 [PATCH net] r8152: Use MAC address from correct device tree node Thierry Reding
2020-08-07 8:06 ` EJ Hsu
2020-08-08 21:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808.142738.431277384120054736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ejh@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).