From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Adams <jwadams@google.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [RFC PATCH 3/7] core/metricfs: metric for kernel warnings
Date: Sat, 8 Aug 2020 07:45:04 +0200 [thread overview]
Message-ID: <20200808054504.GD1037591@kroah.com> (raw)
In-Reply-To: <20200807212916.2883031-4-jwadams@google.com>
On Fri, Aug 07, 2020 at 02:29:12PM -0700, Jonathan Adams wrote:
> Count kernel warnings by function name of the caller.
>
> Each time WARN() is called, which includes WARN_ON(), increment a counter
> in a 256-entry hash table. The table key is the entry point of the calling
> function, which is found using kallsyms.
Why is this needed?
As systems seem to like to reboot when WARN() is called, will this only
ever show 1? :)
>
> We store the name of the function in the table (because it may be a
> module address); reporting the metric just walks the table and prints
> the values.
>
> The "warnings" metric is cumulative.
If you are creating specific files in a specific location that people
can rely on, shouldn't they show up in Documentation/ABI/ as well?
But again, is this feature something that anyone really needs/wants?
What can the number of warnings show you?
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-08 5:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 21:29 [RFC PATCH 0/7] metricfs metric file system and examples Jonathan Adams
2020-08-07 21:29 ` [RFC PATCH 1/7] core/metricfs: Create metricfs, standardized files under debugfs Jonathan Adams
2020-08-08 5:41 ` Greg KH
2020-08-07 21:29 ` [RFC PATCH 2/7] core/metricfs: add support for percpu metricfs files Jonathan Adams
2020-08-08 5:43 ` Greg KH
2020-08-07 21:29 ` [RFC PATCH 3/7] core/metricfs: metric for kernel warnings Jonathan Adams
2020-08-08 5:45 ` Greg KH [this message]
2020-08-07 21:29 ` [RFC PATCH 4/7] core/metricfs: expose softirq information through metricfs Jonathan Adams
2020-08-08 5:46 ` Greg KH
2020-08-07 21:29 ` [RFC PATCH 5/7] core/metricfs: expose scheduler stat " Jonathan Adams
2020-08-07 21:29 ` [RFC PATCH 6/7] core/metricfs: expose x86-specific irq " Jonathan Adams
2020-08-13 10:11 ` Thomas Gleixner
2020-08-13 11:47 ` Paolo Bonzini
2020-08-13 12:13 ` Thomas Gleixner
2020-08-13 14:10 ` Paolo Bonzini
2020-08-13 14:21 ` Thomas Gleixner
2020-08-07 21:29 ` [RFC PATCH 7/7] net-metricfs: Export /proc/net/dev via metricfs Jonathan Adams
2020-08-08 2:06 ` [RFC PATCH 0/7] metricfs metric file system and examples Andrew Lunn
2020-08-08 15:59 ` David Ahern
2020-08-10 18:20 ` Jakub Kicinski
2020-08-10 9:23 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808054504.GD1037591@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jmattson@google.com \
--cc=jwadams@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).