* [PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated
@ 2020-08-10 16:55 Ronak Doshi
2020-08-10 19:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ronak Doshi @ 2020-08-10 16:55 UTC (permalink / raw)
To: netdev
Cc: Ronak Doshi, VMware, Inc., David S. Miller, Jakub Kicinski, open list
Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload
support") added support for encapsulation offload. However, while
calculating tcp hdr length, it does not take into account if the
packet is encapsulated or not.
This patch fixes this issue by using correct reference for inner
tcp header.
Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
Signed-off-by: Ronak Doshi <doshir@vmware.com>
Acked-by: Guolin Yang <gyang@vmware.com>
---
Changes in v2:
- Undo changes to driver version
- Fixed commit message
drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index ca395f9679d0..2818015324b8 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -886,7 +886,8 @@ vmxnet3_parse_hdr(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
switch (protocol) {
case IPPROTO_TCP:
- ctx->l4_hdr_size = tcp_hdrlen(skb);
+ ctx->l4_hdr_size = skb->encapsulation ? inner_tcp_hdrlen(skb) :
+ tcp_hdrlen(skb);
break;
case IPPROTO_UDP:
ctx->l4_hdr_size = sizeof(struct udphdr);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated
2020-08-10 16:55 [PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated Ronak Doshi
@ 2020-08-10 19:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-10 19:10 UTC (permalink / raw)
To: doshir; +Cc: netdev, pv-drivers, kuba, linux-kernel
From: Ronak Doshi <doshir@vmware.com>
Date: Mon, 10 Aug 2020 09:55:55 -0700
> Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload
> support") added support for encapsulation offload. However, while
> calculating tcp hdr length, it does not take into account if the
> packet is encapsulated or not.
>
> This patch fixes this issue by using correct reference for inner
> tcp header.
>
> Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
> Signed-off-by: Ronak Doshi <doshir@vmware.com>
> Acked-by: Guolin Yang <gyang@vmware.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-10 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 16:55 [PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated Ronak Doshi
2020-08-10 19:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).