From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE2CC433DF for ; Mon, 10 Aug 2020 20:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B69020656 for ; Mon, 10 Aug 2020 20:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597090863; bh=bK7hhnLgOAln2zyq3Jy0rJ9cnV5JlvAPE7gm22oNbXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=SsEsrOq10d9SaBSyRnMPOrjHkZw4d3Lu+Ops9FMOuf9ZjWyzscobcj33UYBiEl4gQ uay8+ns91GOrAcAlpS5g6LHak/qQaYHs5L8dbXhJVuVTOp69RttIfG5wR+vJPtt6lD PDmlnkSMqtKi/eAqRHjJbwCykLjI6b5oA+eOTn9g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbgHJUVC (ORCPT ); Mon, 10 Aug 2020 16:21:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:57886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbgHJUVC (ORCPT ); Mon, 10 Aug 2020 16:21:02 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F85620656; Mon, 10 Aug 2020 20:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597090861; bh=bK7hhnLgOAln2zyq3Jy0rJ9cnV5JlvAPE7gm22oNbXA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pNdw7IFQbTTUZJQV4ykCEdAAkKkHiioh9zDxPhGU/bQX+u/EsGFOAi8c80fnKmCaF bKcnvmlQF90XQjKBRqxzDTjmiuj4lY20kpwUJYUfzIMqDTHiMznYwcIW5bDIf3AphS SS5YJrCKoFTFfOu2lEjGfAaF3TyVR33KK23TgKUM= Date: Mon, 10 Aug 2020 13:20:59 -0700 From: Jakub Kicinski To: Murali Karicheri Cc: "netdev@vger.kernel.org" , nikolay@cumulusnetworks.com Subject: Re: HSR/PRP LRE Stats - What is the right user space interface? Message-ID: <20200810132059.4840ac5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <0c743d6e-4a6d-5dcd-88c0-31c6d0971726@ti.com> References: <0c743d6e-4a6d-5dcd-88c0-31c6d0971726@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 10 Aug 2020 15:55:35 -0400 Murali Karicheri wrote: > Hi Netdev experts, > > IEC-62439 defines following LRE stats:- > > "lreTxA", > "lreTxB", > "lreTxC", > "lreErrWrongLanA", > "lreErrWrongLanB", > "lreErrWrongLanC", > "lreRxA", > "lreRxB", > "lreRxC", > "lreErrorsA", > "lreErrorsB", > "lreErrorsC", > "lreNodes", > "lreProxyNodes", > "lreUniqueRxA", > "lreUniqueRxB", > "lreUniqueRxC", > "lreDuplicateRxA", > "lreDuplicateRxB", > "lreDuplicateRxC", > "lreMultiRxA", > "lreMultiRxB", > "lreMultiRxC", > "lreOwnRxA", > "lreOwnRxB", > > These stats are defined also in the IEC-62439 MIB definition. So > this MIB support is required in Net-SNMP and that requires a proper > kernel interface to pull the values from the HSR or PRP > LRE (Link Redundancy Entity). What is the right interface for this? > Internally TI uses /proc interface for this. But want to check with > community before sending a patch for this. One choice is ethtool for > this. Or something else? Would appreciate if someone can clarify so > that I can work towards a patch for the same. Are these collected by HW, or also by the bridge code? Adding a new IFLA_STATS_LINK_* may be the right choice.