From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B33C433E0 for ; Mon, 10 Aug 2020 19:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF13822CAF for ; Mon, 10 Aug 2020 19:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597087885; bh=8Tzd0Aos4HqBT8yzWLrxitqCDm+fIO4pv5Jqk510z8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cJbzLlYmJdIVNUx/y/jkpQEUUfwfIlAn2C/JAXSGl5F5JiODehqIYPCQOAvapZwdR 7SaWXUqOsvtGSehBT3JmSG5YTac0YkHSmuWrIguMqJ9D5qIaIWQiAK/IPM9fH2eJhW Us6B8s5ZjaigsTyau8WjUpb5wL5gE3KuZjPMkwDU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728843AbgHJTKK (ORCPT ); Mon, 10 Aug 2020 15:10:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:37134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728828AbgHJTKH (ORCPT ); Mon, 10 Aug 2020 15:10:07 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19D2921775; Mon, 10 Aug 2020 19:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597086606; bh=8Tzd0Aos4HqBT8yzWLrxitqCDm+fIO4pv5Jqk510z8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Chds1ofYJ+P4YMIYEMKpQmuBRK061cCtf+Bj3hV9rB8+FcFe8j9RFBzBGIG19EZUg BLaVKf8xRkjCICZywmbl0SFnJtQagVtz1iKZzdDdSZxdygh29JgamryatmV9o/OhuL aNUbaPRqteKgPn6VFOKzoQoYsH/s869AGoQmBfEI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shannon Nelson , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.8 49/64] ionic: update eid test for overflow Date: Mon, 10 Aug 2020 15:08:44 -0400 Message-Id: <20200810190859.3793319-49-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200810190859.3793319-1-sashal@kernel.org> References: <20200810190859.3793319-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Shannon Nelson [ Upstream commit 3fbc9bb6ca32d12d4d32a7ae32abef67ac95f889 ] Fix up our comparison to better handle a potential (but largely unlikely) wrap around. Signed-off-by: Shannon Nelson Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index e55d41546cff2..aa93f9a6252df 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -723,7 +723,7 @@ static bool ionic_notifyq_service(struct ionic_cq *cq, eid = le64_to_cpu(comp->event.eid); /* Have we run out of new completions to process? */ - if (eid <= lif->last_eid) + if ((s64)(eid - lif->last_eid) <= 0) return false; lif->last_eid = eid; -- 2.25.1