From: David Miller <davem@davemloft.net>
To: xiangxia.m.yue@gmail.com
Cc: joel@joelfernandes.org, jknoos@google.com, gvrose8192@gmail.com,
urezki@gmail.com, paulmck@kernel.org, dev@openvswitch.org,
netdev@vger.kernel.org, rcu@vger.kernel.org
Subject: Re: [PATCH] net: openvswitch: introduce common code for flushing flows
Date: Tue, 11 Aug 2020 10:23:39 -0700 (PDT) [thread overview]
Message-ID: <20200811.102339.667052777479413338.davem@davemloft.net> (raw)
In-Reply-To: <20200811011001.75690-1-xiangxia.m.yue@gmail.com>
From: xiangxia.m.yue@gmail.com
Date: Tue, 11 Aug 2020 09:10:01 +0800
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 42f8cc70bb2c..5fec47e62615 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -1756,6 +1756,9 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct genl_info *info)
> /* Called with ovs_mutex. */
> static void __dp_destroy(struct datapath *dp)
> {
> + struct flow_table *table = &dp->table;
> + struct table_instance *ufid_ti = ovsl_dereference(table->ufid_ti);
> + struct table_instance *ti = ovsl_dereference(table->ti);
> int i;
>
> for (i = 0; i < DP_VPORT_HASH_BUCKETS; i++) {
Please use reverse christmas tree ordering for local variables.
next prev parent reply other threads:[~2020-08-11 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 1:10 [PATCH] net: openvswitch: introduce common code for flushing flows xiangxia.m.yue
2020-08-11 17:23 ` David Miller [this message]
2020-08-12 0:47 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811.102339.667052777479413338.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=gvrose8192@gmail.com \
--cc=jknoos@google.com \
--cc=joel@joelfernandes.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).