From: Vladimir Oltean <olteanv@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: David Miller <davem@davemloft.net>,
Jiafei.Pan@nxp.com, kuba@kernel.org, netdev@vger.kernel.org,
claudiu.manoil@nxp.com, ioana.ciornei@nxp.com, yangbo.lu@nxp.com,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT
Date: Wed, 12 Aug 2020 17:34:30 +0300 [thread overview]
Message-ID: <20200812143430.xuzg2ddsl7ouhn5m@skbuf> (raw)
In-Reply-To: <20200812135144.hpsfgxusojdrsewl@linutronix.de>
On Wed, Aug 12, 2020 at 03:51:44PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-08-03 18:21:45 [-0700], David Miller wrote:
> > From: Vladimir Oltean <olteanv@gmail.com>
> > > The driver calls napi_schedule_irqoff() from a context where, in RT,
> > > hardirqs are not disabled, since the IRQ handler is force-threaded.
> …
> > >
> > > Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> > Applied.
>
> Could these two patches be forwarded -stable, please? The changelog
> describes this as a problem on PREEMPT_RT but this also happens on !RT
> with the `threadirqs' commandline switch.
>
> Sebastian
I expect the driver maintainers to have something to say about this. I
didn't test on stable kernels, and at least for dpaa2-eth, the change
would need to go pretty deep down the stable line.
Also, not really sure who is using the threadirqs option except for
testing purposes.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-08-12 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 20:10 [PATCH net-next 1/2] dpaa2-eth: use napi_schedule to be compatible with PREEMPT_RT Vladimir Oltean
2020-08-03 20:10 ` [PATCH net-next 2/2] enetc: " Vladimir Oltean
2020-08-04 1:21 ` David Miller
2020-08-12 13:51 ` Sebastian Andrzej Siewior
2020-08-12 14:34 ` Vladimir Oltean [this message]
2020-08-12 15:13 ` Sebastian Andrzej Siewior
2020-08-24 10:59 ` Vladimir Oltean
2020-08-04 1:21 ` [PATCH net-next 1/2] dpaa2-eth: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812143430.xuzg2ddsl7ouhn5m@skbuf \
--to=olteanv@gmail.com \
--cc=Jiafei.Pan@nxp.com \
--cc=bigeasy@linutronix.de \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).