From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2208C433E0 for ; Thu, 13 Aug 2020 00:54:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB11920774 for ; Thu, 13 Aug 2020 00:54:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgHMAyL (ORCPT ); Wed, 12 Aug 2020 20:54:11 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:54376 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgHMAyL (ORCPT ); Wed, 12 Aug 2020 20:54:11 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k61VP-0001UK-DW; Thu, 13 Aug 2020 10:54:08 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 13 Aug 2020 10:54:07 +1000 Date: Thu, 13 Aug 2020 10:54:07 +1000 From: Herbert Xu To: Srujana Challa Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-crypto@vger.kernel.org, schandran@marvell.com, pathreya@marvell.com, sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com Subject: Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine Message-ID: <20200813005407.GB24593@gondor.apana.org.au> References: <1596809360-12597-1-git-send-email-schalla@marvell.com> <1596809360-12597-3-git-send-email-schalla@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596809360-12597-3-git-send-email-schalla@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Aug 07, 2020 at 07:39:19PM +0530, Srujana Challa wrote: > > +#if defined(CONFIG_ARM64) > +static inline long otx2_lmt_flush(void *ioreg) > +{ > + long result = 0; > + > + __asm__ volatile(".cpu generic+lse\n" > + "ldeor xzr, %0, [%1]\n" > + : "=r" (result) > + : "r" (ioreg) : "memory"); > + > + return result; > +} > + > +#else > +#define otx2_lmt_flush(addr) ({ 0; }) > +#endif This is not acceptable. Please work out a way with the ARM folks to fix this without adding assembly code in a driver. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt