From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172A3C433E1 for ; Thu, 13 Aug 2020 13:01:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2238207DA for ; Thu, 13 Aug 2020 13:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597323695; bh=1KOO84jBp9k+vGNx1PLhbzn8bP6+PJCQeuZYx6xdx/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jDDfYVU1StexNWBurBG5Y5HvFmhdOwihoc6zqL2vyFKBx/yvxZ7bXb92oghavQuWv 1xo+zHxWI+C2CwXU0zIPaVbU6VoyF465pEd2tHqzvmR0Zgh2dpwKuFiVawBawhNRdt 7hXqtV/nkby6YJ+lqYRgZj6d9317CbX1Aq74mOTs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbgHMNBb (ORCPT ); Thu, 13 Aug 2020 09:01:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:56630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgHMNBb (ORCPT ); Thu, 13 Aug 2020 09:01:31 -0400 Received: from quaco.ghostprotocols.net (177.207.136.251.dynamic.adsl.gvt.net.br [177.207.136.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60C992078D; Thu, 13 Aug 2020 13:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597323690; bh=1KOO84jBp9k+vGNx1PLhbzn8bP6+PJCQeuZYx6xdx/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kGUPXWdcoZ4yL8eY3VdCnSHYNaNMlfsZcxOlOSzA8v0O3rXynGwN3qL0o1WXOwjA/ 0k1o1iLSWtsn+c5gslmMgNly9ZNQGMivPXorPSscTJoNJ77bRLo7XvAj8NlJ5kOYCx r+NrNYsTG0aoGpG61GcbkIQO4pMk7BeqCjKCJxW4= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id A86BE4097F; Thu, 13 Aug 2020 10:01:27 -0300 (-03) Date: Thu, 13 Aug 2020 10:01:27 -0300 From: Arnaldo Carvalho de Melo To: Tom Hebb Cc: Daniel =?iso-8859-1?Q?D=EDaz?= , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Arnaldo Carvalho de Melo , Jiri Olsa , Stephane Eranian , Namhyung Kim , open list , "open list:BPF (Safe dynamic programs and tools)" , "open list:BPF (Safe dynamic programs and tools)" Subject: Re: [PATCH] tools build feature: Quote CC and CXX for their arguments Message-ID: <20200813130127.GO13995@kernel.org> References: <20200812221518.2869003-1-daniel.diaz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Em Wed, Aug 12, 2020 at 07:31:32PM -0700, Tom Hebb escreveu: > On Wed, Aug 12, 2020 at 3:15 PM Daniel Díaz wrote: > > Makefile.config:414: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop. > > Makefile.perf:230: recipe for target 'sub-make' failed > > make[1]: *** [sub-make] Error 2 > > Makefile:69: recipe for target 'all' failed > > make: *** [all] Error 2 > > > > With CC and CXX quoted, some of those features are now detected. > > > > Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent") > > > > Signed-off-by: Daniel Díaz > > Whoops, I'm the one who introduced this issue. Fix looks good, thanks! > > Reviewed-by: Thomas Hebb > Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent") Thanks, applied. - Arnaldo