From: David Miller <davem@davemloft.net>
To: rdunlap@infradead.org
Cc: linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
netdev@vger.kernel.org
Subject: Re: [PATCH] phylink: <linux/phylink.h>: fix function prototype kernel-doc warning
Date: Mon, 17 Aug 2020 11:46:29 -0700 (PDT) [thread overview]
Message-ID: <20200817.114629.1895503086750807628.davem@davemloft.net> (raw)
In-Reply-To: <f99bacca-0868-dff0-ff72-ebe8b8749270@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sun, 16 Aug 2020 22:43:54 -0700
> On 8/16/20 9:14 PM, David Miller wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>> Date: Sun, 16 Aug 2020 15:25:49 -0700
>>
>>> Fix a kernel-doc warning for the pcs_config() function prototype:
>>>
>>> ../include/linux/phylink.h:406: warning: Excess function parameter 'permit_pause_to_mac' description in 'pcs_config'
>>>
>>> Fixes: 7137e18f6f88 ("net: phylink: add struct phylink_pcs")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> There's no definition of this function anywhere. Maybe just remove all of
>> this?
>>
>
> It's for documentation purposes...
>
> It's a "method" (callback) function.
I see, that's an unfortunate shortcoming of kerneldoc.
Applied, thanks.
next prev parent reply other threads:[~2020-08-17 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 22:25 [PATCH] phylink: <linux/phylink.h>: fix function prototype kernel-doc warning Randy Dunlap
2020-08-17 4:14 ` David Miller
2020-08-17 5:43 ` Randy Dunlap
2020-08-17 18:46 ` David Miller [this message]
2020-08-17 7:26 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817.114629.1895503086750807628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).