From: Steffen Klassert <steffen.klassert@secunet.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: <netdev@vger.kernel.org>, Xiumei Mu <xmu@redhat.com>
Subject: Re: [PATCH ipsec] espintcp: restore IP CB before handing the packet to xfrm
Date: Mon, 17 Aug 2020 16:01:32 +0200 [thread overview]
Message-ID: <20200817140132.GQ13121@gauss3.secunet.de> (raw)
In-Reply-To: <b3c2d120af02d34c0ab6e67b897be502c5106dca.1597328612.git.sd@queasysnail.net>
On Thu, Aug 13, 2020 at 04:24:04PM +0200, Sabrina Dubroca wrote:
> Xiumei reported a bug with espintcp over IPv6 in transport mode,
> because xfrm6_transport_finish expects to find IP6CB data (struct
> inet6_skb_cb). Currently, espintcp zeroes the CB, but the relevant
> part is actually preserved by previous layers (first set up by tcp,
> then strparser only zeroes a small part of tcp_skb_tb), so we can just
> relocate it to the start of skb->cb.
>
> Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)")
> Reported-by: Xiumei Mu <xmu@redhat.com>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied, thanks Sabrina!
prev parent reply other threads:[~2020-08-17 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:24 [PATCH ipsec] espintcp: restore IP CB before handing the packet to xfrm Sabrina Dubroca
2020-08-17 14:01 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817140132.GQ13121@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=xmu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).