* [PATCH net-next] selftests: disable rp_filter for icmp_redirect.sh
@ 2020-08-17 15:43 David Ahern
2020-08-17 22:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2020-08-17 15:43 UTC (permalink / raw)
To: netdev, kuba, davem; +Cc: David Ahern
h1 is initially configured to reach h2 via r1 rather than the
more direct path through r2. If rp_filter is set and inherited
for r2, forwarding fails since the source address of h1 is
reachable from eth0 vs the packet coming to it via r1 and eth1.
Since rp_filter setting affects the test, explicitly reset it.
Signed-off-by: David Ahern <dsahern@kernel.org>
---
tools/testing/selftests/net/icmp_redirect.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/icmp_redirect.sh b/tools/testing/selftests/net/icmp_redirect.sh
index 18c5de53558a..bf361f30d6ef 100755
--- a/tools/testing/selftests/net/icmp_redirect.sh
+++ b/tools/testing/selftests/net/icmp_redirect.sh
@@ -180,6 +180,8 @@ setup()
;;
r[12]) ip netns exec $ns sysctl -q -w net.ipv4.ip_forward=1
ip netns exec $ns sysctl -q -w net.ipv4.conf.all.send_redirects=1
+ ip netns exec $ns sysctl -q -w net.ipv4.conf.default.rp_filter=0
+ ip netns exec $ns sysctl -q -w net.ipv4.conf.all.rp_filter=0
ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=1
ip netns exec $ns sysctl -q -w net.ipv6.route.mtu_expires=10
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] selftests: disable rp_filter for icmp_redirect.sh
2020-08-17 15:43 [PATCH net-next] selftests: disable rp_filter for icmp_redirect.sh David Ahern
@ 2020-08-17 22:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-17 22:00 UTC (permalink / raw)
To: dsahern; +Cc: netdev, kuba
From: David Ahern <dsahern@kernel.org>
Date: Mon, 17 Aug 2020 09:43:33 -0600
> h1 is initially configured to reach h2 via r1 rather than the
> more direct path through r2. If rp_filter is set and inherited
> for r2, forwarding fails since the source address of h1 is
> reachable from eth0 vs the packet coming to it via r1 and eth1.
> Since rp_filter setting affects the test, explicitly reset it.
>
> Signed-off-by: David Ahern <dsahern@kernel.org>
As a bug fix I've applied this to 'net', thanks David.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-17 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 15:43 [PATCH net-next] selftests: disable rp_filter for icmp_redirect.sh David Ahern
2020-08-17 22:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).