From: Helmut Grohne <helmut.grohne@intenta.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] net: dsa: microchip: delete dead code
Date: Tue, 18 Aug 2020 09:57:36 +0200 [thread overview]
Message-ID: <20200818075736.GA1698@laureti-dev> (raw)
In-Reply-To: <73ba5a2a-786d-e847-598a-20cdeef2e1c0@gmail.com>
Hi Florian,
On Mon, Aug 17, 2020 at 08:18:41AM -0700, Florian Fainelli wrote:
> net-next is currently closed at the moment, and these patches are clearly
> targeted at that tree:
I agree that these are clearly net-next material.
> http://vger.kernel.org/~davem/net-next.html
It says "Come in we're open" for me. Maybe that changed over night and I
was just a day early? I'll check this for future submissions.
> Also, please provide a commit message, even if it is only paraphrasing what
> the subject does. The changes do look good, so once you fix that, we should
> be good.
I'm all for writing good commit messages and if you look into the few
commits I've authored thus far, you see that I usually do explain them
in detail. In these cases however, I'm left wondering what value any
further explanation would add. Repeating the subject does not make sense
to me.
I feel that we're overdoing it here and that there are more important
aspects to be improved about the driver. I'll be focusing on those.
Helmut
prev parent reply other threads:[~2020-08-18 7:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 8:33 [RFC PATCH] net: dsa: microchip: delete dead code Helmut Grohne
2020-07-22 14:39 ` Andrew Lunn
2020-07-23 4:24 ` Helmut Grohne
2020-07-25 17:41 ` Andrew Lunn
2020-08-17 14:55 ` [PATCH v2 0/6] " Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 1/6] net: dsa: microchip: delete unused member ksz_port.phy Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 2/6] net: dsa: microchip: delete unused member ksz_port.sgmii Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 3/6] net: dsa: microchip: delete unused member ksz_port.force Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 4/6] net: dsa: microchip: delete unused member ksz_device.last_port Helmut Grohne
2020-08-17 14:59 ` [PATCH v2 5/6] net: dsa: microchip: delete unused member ksz_device.regs_size Helmut Grohne
2020-08-17 14:59 ` [PATCH v2 6/6] net: dsa: microchip: delete unused member ksz_device.overrides Helmut Grohne
2020-08-17 15:18 ` [PATCH v2 0/6] net: dsa: microchip: delete dead code Florian Fainelli
2020-08-18 7:57 ` Helmut Grohne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818075736.GA1698@laureti-dev \
--to=helmut.grohne@intenta.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).