From: David Miller <davem@davemloft.net>
To: bigeasy@linutronix.de
Cc: irusskikh@marvell.com, netdev@vger.kernel.org,
mstarovoitov@marvell.com, kuba@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout
Date: Wed, 19 Aug 2020 16:25:48 -0700 (PDT) [thread overview]
Message-ID: <20200819.162548.1211800869018001410.davem@davemloft.net> (raw)
In-Reply-To: <20200818161439.3dkf6jzp3vuwmvvh@linutronix.de>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Tue, 18 Aug 2020 18:14:39 +0200
> Commit
> 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature")
>
> implemented a read callback with an udelay(10000U). This fails to
> compile on ARM because the delay is >1ms. I doubt that it is needed to
> spin for 10ms even if possible on x86.
>
> From looking at the code, the context appears to be preemptible so using
> usleep() should work and avoid busy spinning.
>
> Use readx_poll_timeout() in the poll loop.
>
> Cc: Mark Starovoytov <mstarovoitov@marvell.com>
> Cc: Igor Russkikh <irusskikh@marvell.com>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Applied, thanks.
prev parent reply other threads:[~2020-08-19 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 16:14 [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout Sebastian Andrzej Siewior
2020-08-19 16:19 ` Guenter Roeck
2020-08-20 10:17 ` [EXT] " Igor Russkikh
2020-08-19 23:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819.162548.1211800869018001410.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bigeasy@linutronix.de \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=mstarovoitov@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).