From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alex Elder <elder@linaro.org>, Networking <netdev@vger.kernel.org>
Subject: Re: COMPILE_TEST
Date: Tue, 1 Sep 2020 17:17:38 -0700 [thread overview]
Message-ID: <20200901171738.23af6c63@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200901214852.GA3050651@lunn.ch>
On Tue, 1 Sep 2020 23:48:52 +0200 Andrew Lunn wrote:
> On Tue, Sep 01, 2020 at 03:22:31PM -0500, Alex Elder wrote:
> > Jakub, you suggested/requested that the Qualcomm IPA driver get
> > built when the COMPILE_TEST config option is enabled. I started
> > working on this a few months ago but didn't finish, and picked
> > it up again today. I'd really like to get this done soon.
> >
> > The QCOM_IPA config option depends on and selects other things,
> > and those other things depend on and select still more config
> > options. I've worked through some of these, but now question
> > whether this is even the right approach. Should I try to ensure
> > all the code the IPA driver depends on and selects *also* gets
> > built when COMPILE_TEST is enabled? Or should I try to minimize
> > the impact on other code by making IPA config dependencies and
> > selections also depend on the value of COMPILE_TEST?
> >
> > Is there anything you know of that describes best practice for
> > enabling a config option when COMPILE_TEST is enabled?
>
> Hi Alex
>
> In general everything which can be build with COMPILE_TEST should be
> built with COMPILE_TEST. So generally it just works, because
> everything selected should already be selected because they already
> have COMPILE_TEST.
>
> Correctly written drivers should compile for just about any
> architecture. If they don't it suggests they are not using the APIs
> correctly, and should be fixed.
>
> If the dependencies have not had COMPILE_TEST before, you are probably
> in for some work, but in the end all the drivers will be of better
> quality, and get build tested a lot more.
Nothing to add :) I'm not aware of any codified best practices.
next prev parent reply other threads:[~2020-09-02 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 20:22 COMPILE_TEST Alex Elder
2020-09-01 21:48 ` COMPILE_TEST Andrew Lunn
2020-09-02 0:17 ` Jakub Kicinski [this message]
2020-09-02 0:52 ` COMPILE_TEST Randy Dunlap
2020-09-02 11:46 ` COMPILE_TEST Alex Elder
2020-09-02 12:23 ` COMPILE_TEST Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901171738.23af6c63@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=elder@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).