From: David Miller <davem@davemloft.net>
To: luobin9@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
luoxianjun@huawei.com, yin.yinshi@huawei.com,
cloud.wangxiaoyun@huawei.com, chiqijun@huawei.com
Subject: Re: [PATCH net 3/3] hinic: fix bug of send pkts while setting channels
Date: Wed, 02 Sep 2020 12:52:57 -0700 (PDT) [thread overview]
Message-ID: <20200902.125257.1961904187228004830.davem@davemloft.net> (raw)
In-Reply-To: <20200902094145.12216-4-luobin9@huawei.com>
From: Luo bin <luobin9@huawei.com>
Date: Wed, 2 Sep 2020 17:41:45 +0800
> @@ -531,6 +531,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
> struct hinic_txq *txq;
> struct hinic_qp *qp;
>
> + if (unlikely(!netif_carrier_ok(netdev))) {
> + dev_kfree_skb_any(skb);
> + return NETDEV_TX_OK;
> + }
As Eric said, these kinds of tests should not be placed in the fast path
of the driver.
If you invoke close and the core networking still sends packets to the
driver, that's a bug that needs to be fixed in the core networking.
next prev parent reply other threads:[~2020-09-02 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 9:41 [PATCH net 0/3] hinic: BugFixes Luo bin
2020-09-02 9:41 ` [PATCH net 1/3] hinic: bump up the timeout of SET_FUNC_STATE cmd Luo bin
2020-09-02 9:41 ` [PATCH net 2/3] hinic: bump up the timeout of UPDATE_FW cmd Luo bin
2020-09-02 9:41 ` [PATCH net 3/3] hinic: fix bug of send pkts while setting channels Luo bin
2020-09-02 10:16 ` Eric Dumazet
2020-09-03 14:18 ` luobin (L)
2020-09-02 19:52 ` David Miller [this message]
2020-09-03 14:27 ` luobin (L)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902.125257.1961904187228004830.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luobin9@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).