From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD8EC433E2 for ; Fri, 4 Sep 2020 13:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A15A620658 for ; Fri, 4 Sep 2020 13:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730611AbgIDNxN (ORCPT ); Fri, 4 Sep 2020 09:53:13 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42974 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730690AbgIDNxJ (ORCPT ); Fri, 4 Sep 2020 09:53:09 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kEC99-00DCbH-FY; Fri, 04 Sep 2020 15:52:55 +0200 Date: Fri, 4 Sep 2020 15:52:55 +0200 From: Andrew Lunn To: Helmut Grohne Cc: Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Woojung Huh , Microchip Linux Driver Support , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Rob Herring , devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] net: dsa: microchip: look for phy-mode in port nodes Message-ID: <20200904135255.GM3112546@lunn.ch> References: <20200824.153738.1423061044322742575.davem@davemloft.net> <20200904081438.GA14387@laureti-dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904081438.GA14387@laureti-dev> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > + dev_warn(dev->dev, > + "Using legacy switch \"phy-mode\" missing on port %d node. Please update your device tree.\n", That message seems mangled. > + if (!p->interface) { > + if (dev->compat_interface) { > + dev_warn(dev->dev, > + "Using legacy switch \"phy-mode\" missing on port %d node. Please update your device tree.\n", > + i); Same warning again. Andrew