From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436BEC2BB84 for ; Fri, 4 Sep 2020 18:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 057B620665 for ; Fri, 4 Sep 2020 18:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgIDSin (ORCPT ); Fri, 4 Sep 2020 14:38:43 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43630 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgIDSim (ORCPT ); Fri, 4 Sep 2020 14:38:42 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kEGba-00DEuJ-3F; Fri, 04 Sep 2020 20:38:34 +0200 Date: Fri, 4 Sep 2020 20:38:34 +0200 From: Andrew Lunn To: Sunil Kovvuri Goutham Cc: Herbert Xu , Srujana Challa , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-crypto@vger.kernel.org" , Suheil Chandran , Narayana Prasad Raju Athreya , Linu Cherian , Geethasowjanya Akula , Jerin Jacob Kollanukkaran , Ard Biesheuvel Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine Message-ID: <20200904183834.GS3112546@lunn.ch> References: <1596809360-12597-1-git-send-email-schalla@marvell.com> <1596809360-12597-3-git-send-email-schalla@marvell.com> <20200813005407.GB24593@gondor.apana.org.au> <20200904135044.GA2836@gondor.apana.org.au> <20200904141744.GA3092@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 04, 2020 at 04:36:29PM +0000, Sunil Kovvuri Goutham wrote: > > > > -----Original Message----- > > From: Herbert Xu > > Sent: Friday, September 4, 2020 7:48 PM > > To: Srujana Challa > > Cc: davem@davemloft.net; netdev@vger.kernel.org; linux- > > crypto@vger.kernel.org; Suheil Chandran ; > > Narayana Prasad Raju Athreya ; Sunil Kovvuri > > Goutham ; Linu Cherian ; > > Geethasowjanya Akula ; Jerin Jacob Kollanukkaran > > ; Ard Biesheuvel > > Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for > > OCTEONTX2 CPT engine > > > > On Fri, Sep 04, 2020 at 02:14:34PM +0000, Srujana Challa wrote: > > > > > > Since LMT store is our platform specific, it cannot be generalized to all > > ARM64. > > > > I'm not asking you to generalise it to all of ARM64. I'm asking you to move > > this into a header file under arch/arm64 that can then be shared by both your > > crypto driver and your network driver so you don't duplicate this > > everywhere. > > > > For ARM64 , except erratas other platform or machine dependent stuff are not allowed inside arch/arm64. > Also an earlier attempt by us to add few APIs addressing 128bit operations were not allowed by ARM folks > as they don't work in a generic way and are SOC specific. > http://lkml.iu.edu/hypermail/linux/kernel/1801.3/02211.html Maybe put it in include/linux/soc/ ? Andrew