From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A5BC2BC11 for ; Fri, 11 Sep 2020 16:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 181C220855 for ; Fri, 11 Sep 2020 16:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbgIKQZe (ORCPT ); Fri, 11 Sep 2020 12:25:34 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:41815 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbgIKP0P (ORCPT ); Fri, 11 Sep 2020 11:26:15 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C82D4308; Fri, 11 Sep 2020 11:26:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 11 Sep 2020 11:26:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=mFlqUt /8BLKg7P43W/phyBdp9DFVhBsV70oZNNCSdio=; b=mwDhN41fxSABGCCjXtujRl w7fgjU+jAu14hqbEDFctJqb5cvSgXQVZ1oOIOE+pkNq276BwM74dQus4orHYuz0V 3Fn4fKYFK13S0iMwd/zfUDWeEjn+Sr51yf2KUfG+WCThY7blzcI8AsLgcuhwGCNk JFOcuBdrGifTnwgA3uj+f2klkUrT7c7jF9vjKKCRGfIbojk9dWaIxZQqZWp+ZtKN /G/+fHeogPD3fyqms8ovPlKV887Jt4gsdfdZ09FNmRrBE0bx3rU2FL/jkLpU0iuN QVP1/SUa8N9RbcysVxq61ajyB5Nm7oRciO0Obt2GxxemaFjRl4FR+dkxbAjZs5/Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehledgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepkeegrddvvdelrdefiedrudefudenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-36-131.inter.net.il [84.229.36.131]) by mail.messagingengine.com (Postfix) with ESMTPA id C7D0E3064683; Fri, 11 Sep 2020 11:26:03 -0400 (EDT) Date: Fri, 11 Sep 2020 18:26:01 +0300 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com, mlxsw@nvidia.com, Ido Schimmel Subject: Re: [RFC PATCH net-next 09/22] rtnetlink: Add RTNH_F_TRAP flag Message-ID: <20200911152601.GE3160975@shredder> References: <20200908091037.2709823-1-idosch@idosch.org> <20200908091037.2709823-10-idosch@idosch.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 08, 2020 at 09:02:33AM -0600, David Ahern wrote: > On 9/8/20 3:10 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > The flag indicates to user space that the nexthop is not programmed to > > forward packets in hardware, but rather to trap them. > > please elaborate in the commit message on what 'trap' is doing. I most > likely will forget a few years from now. Reworded to: " rtnetlink: Add RTNH_F_TRAP flag The flag indicates to user space that the nexthop is not programmed to forward packets in hardware, but rather to trap them to the CPU. This is needed, for example, when the MAC of the nexthop neighbour is not resolved and packets should reach the CPU to trigger neighbour resolution. The flag will be used in subsequent patches by netdevsim to test nexthop objects programming to device drivers and in the future by mlxsw as well. Signed-off-by: Ido Schimmel Reviewed-by: David Ahern " > > > > > The flag will be used in subsequent patches by netdevsim to test nexthop > > objects programming to device drivers and in the future by mlxsw as > > well. > > > > Signed-off-by: Ido Schimmel > > --- > > include/uapi/linux/rtnetlink.h | 6 ++++-- > > net/ipv4/fib_semantics.c | 2 ++ > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > Reviewed-by: David Ahern