From: Michal Kubecek <mkubecek@suse.cz>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Thomas Davis <tadavis@lbl.gov>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] bonding: rename slave to link where possible
Date: Wed, 23 Sep 2020 01:23:17 +0200 [thread overview]
Message-ID: <20200922232317.jlbgpsy74q6tbx3a@lion.mk-sys.cz> (raw)
In-Reply-To: <20200922133731.33478-3-jarod@redhat.com>
On Tue, Sep 22, 2020 at 09:37:28AM -0400, Jarod Wilson wrote:
> Getting rid of as much usage of "slave" as we can here, without breaking
> any user-facing API.
>
> Cc: Jay Vosburgh <j.vosburgh@gmail.com>
> Cc: Veaceslav Falico <vfalico@gmail.com>
> Cc: Andy Gospodarek <andy@greyhouse.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Thomas Davis <tadavis@lbl.gov>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
[...]
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 1f602bcf10bd..8e2edebeb61a 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
[...]
> @@ -143,12 +143,12 @@ MODULE_PARM_DESC(mode, "Mode of operation; 0 for balance-rr, "
> module_param(primary, charp, 0);
> MODULE_PARM_DESC(primary, "Primary network device to use");
> module_param(primary_reselect, charp, 0);
> -MODULE_PARM_DESC(primary_reselect, "Reselect primary slave "
> +MODULE_PARM_DESC(primary_reselect, "Reselect primary link "
> "once it comes up; "
> "0 for always (default), "
> "1 for only if speed of primary is "
> "better, "
> - "2 for only on active slave "
> + "2 for only on active link "
> "failure");
> module_param(lacp_rate, charp, 0);
> MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner; "
> @@ -176,24 +176,24 @@ MODULE_PARM_DESC(arp_validate, "validate src/dst of ARP probes; "
> module_param(arp_all_targets, charp, 0);
> MODULE_PARM_DESC(arp_all_targets, "fail on any/all arp targets timeout; 0 for any (default), 1 for all");
> module_param(fail_over_mac, charp, 0);
> -MODULE_PARM_DESC(fail_over_mac, "For active-backup, do not set all slaves to "
> +MODULE_PARM_DESC(fail_over_mac, "For active-backup, do not set all links to "
> "the same MAC; 0 for none (default), "
> "1 for active, 2 for follow");
> -module_param(all_slaves_active, int, 0);
> -MODULE_PARM_DESC(all_slaves_active, "Keep all frames received on an interface "
> - "by setting active flag for all slaves; "
> +module_param(all_links_active, int, 0);
> +MODULE_PARM_DESC(all_links_active, "Keep all frames received on an interface "
> + "by setting active flag for all links; "
> "0 for never (default), 1 for always.");
> module_param(resend_igmp, int, 0);
> MODULE_PARM_DESC(resend_igmp, "Number of IGMP membership reports to send on "
> "link failure");
> -module_param(packets_per_slave, int, 0);
> -MODULE_PARM_DESC(packets_per_slave, "Packets to send per slave in balance-rr "
> - "mode; 0 for a random slave, 1 packet per "
> - "slave (default), >1 packets per slave.");
> +module_param(packets_per_link, int, 0);
> +MODULE_PARM_DESC(packets_per_link, "Packets to send per link in balance-rr "
> + "mode; 0 for a random link, 1 packet per "
> + "link (default), >1 packets per link.");
> module_param(lp_interval, uint, 0);
> MODULE_PARM_DESC(lp_interval, "The number of seconds between instances where "
> "the bonding driver sends learning packets to "
> - "each slaves peer switch. The default is 1.");
> + "each links peer switch. The default is 1.");
Even if the module parameters are deprecated and extremely inconvenient
as a mean of bonding configuration, I would say changing their names
would still count as "breaking the userspace".
Michal
next prev parent reply other threads:[~2020-09-22 23:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 13:37 [PATCH net-next 0/5] bonding: rename bond components Jarod Wilson
2020-09-22 13:37 ` [PATCH net-next 1/5] bonding: rename struct slave member link to link_state Jarod Wilson
2020-09-22 13:37 ` [PATCH net-next 2/5] bonding: rename slave to link where possible Jarod Wilson
2020-09-22 23:23 ` Michal Kubecek [this message]
2020-09-22 23:51 ` David Miller
2020-09-25 11:52 ` Jarod Wilson
2020-09-22 13:37 ` [PATCH net-next 3/5] bonding: rename master to aggregator " Jarod Wilson
2020-09-22 13:37 ` [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces Jarod Wilson
2020-09-22 22:05 ` Jarod Wilson
2020-09-22 23:24 ` Stephen Hemminger
2020-09-22 23:47 ` Jay Vosburgh
2020-09-23 0:01 ` Stephen Hemminger
2020-09-23 16:44 ` Jarod Wilson
2020-09-24 22:47 ` Jay Vosburgh
2020-09-23 4:13 ` kernel test robot
2020-09-23 4:13 ` [RFC PATCH] bonding: linkdesc can be static kernel test robot
2020-09-23 11:29 ` Jarod Wilson
2020-09-22 13:37 ` [PATCH net-next 5/5] bonding: update Documentation for link/aggregator terminology Jarod Wilson
2020-09-22 22:19 ` [PATCH net-next 0/5] bonding: rename bond components Jay Vosburgh
2020-09-25 12:13 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922232317.jlbgpsy74q6tbx3a@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tadavis@lbl.gov \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).