From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: [PATCH net-next 1/3] dpaa2-mac: do not check for both child and parent DTS nodes
Date: Fri, 25 Sep 2020 17:44:19 +0300 [thread overview]
Message-ID: <20200925144421.7811-2-ioana.ciornei@nxp.com> (raw)
In-Reply-To: <20200925144421.7811-1-ioana.ciornei@nxp.com>
There is no need to check if both the MDIO controller node and its
child node, the PCS device, are available since there is no chance that
the child node would be enabled when the parent it's not.
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index 6ff64dd1cf27..cdd1acd0117e 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -267,8 +267,7 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
return 0;
}
- if (!of_device_is_available(node) ||
- !of_device_is_available(node->parent)) {
+ if (!of_device_is_available(node)) {
netdev_err(mac->net_dev, "pcs-handle node not available\n");
return -ENODEV;
}
--
2.25.1
next prev parent reply other threads:[~2020-09-25 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 14:44 [PATCH net-next 0/3] dpaa2-eth: small updates Ioana Ciornei
2020-09-25 14:44 ` Ioana Ciornei [this message]
2020-09-25 16:31 ` [PATCH net-next 1/3] dpaa2-mac: do not check for both child and parent DTS nodes Andrew Lunn
2020-09-25 14:44 ` [PATCH net-next 2/3] dpaa2-eth: no need to check link state right after ndo_open Ioana Ciornei
2020-09-25 14:44 ` [PATCH net-next 3/3] dpaa2-eth: install a single steering rule when SHARED_FS is enabled Ioana Ciornei
2020-09-26 0:14 ` [PATCH net-next 0/3] dpaa2-eth: small updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925144421.7811-2-ioana.ciornei@nxp.com \
--to=ioana.ciornei@nxp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).