From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332D2C4727E for ; Fri, 25 Sep 2020 16:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B22923888 for ; Fri, 25 Sep 2020 16:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729580AbgIYQbX (ORCPT ); Fri, 25 Sep 2020 12:31:23 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55670 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727402AbgIYQbX (ORCPT ); Fri, 25 Sep 2020 12:31:23 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kLqcy-00GBSq-CK; Fri, 25 Sep 2020 18:31:20 +0200 Date: Fri, 25 Sep 2020 18:31:20 +0200 From: Andrew Lunn To: Ioana Ciornei Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/3] dpaa2-mac: do not check for both child and parent DTS nodes Message-ID: <20200925163120.GC3856392@lunn.ch> References: <20200925144421.7811-1-ioana.ciornei@nxp.com> <20200925144421.7811-2-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925144421.7811-2-ioana.ciornei@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 25, 2020 at 05:44:19PM +0300, Ioana Ciornei wrote: > There is no need to check if both the MDIO controller node and its > child node, the PCS device, are available since there is no chance that > the child node would be enabled when the parent it's not. > > Suggested-by: Andrew Lunn > Signed-off-by: Ioana Ciornei Reviewed-by: Andrew Lunn Andrew