From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C08C4727D for ; Sat, 26 Sep 2020 21:19:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D026521531 for ; Sat, 26 Sep 2020 21:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbgIZVSW (ORCPT ); Sat, 26 Sep 2020 17:18:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726382AbgIZVSW (ORCPT ); Sat, 26 Sep 2020 17:18:22 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9AD4C0613CE for ; Sat, 26 Sep 2020 14:18:22 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 84EB811924EB4; Sat, 26 Sep 2020 14:01:33 -0700 (PDT) Date: Sat, 26 Sep 2020 14:18:18 -0700 (PDT) Message-Id: <20200926.141818.1170749837743709005.davem@davemloft.net> To: vladimir.oltean@nxp.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, kuba@kernel.org Subject: Re: [PATCH v3 net-next 00/15] Generic adjustment for flow dissector in DSA From: David Miller In-Reply-To: <20200926193215.1405730-1-vladimir.oltean@nxp.com> References: <20200926193215.1405730-1-vladimir.oltean@nxp.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sat, 26 Sep 2020 14:01:33 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Date: Sat, 26 Sep 2020 22:32:00 +0300 > This is the v2 of a series initially submitted in May: > https://www.spinics.net/lists/netdev/msg651866.html > > The end goal is to get rid of the unintuitive code for the flow > dissector that currently exists in the taggers. It can all be replaced > by a single, common function. > > Some background work needs to be done for that. Especially the ocelot > driver poses some problems, since it has a different tag length between > RX and TX, and I didn't want to make DSA aware of that, since I could > instead make the tag lengths equal. > > Changes in v3: > - Added an optimization (08/15) that makes the generic case not need to > call the .flow_dissect function pointer. Basically .flow_dissect now > currently only exists for sja1105. > - Moved the .promisc_on_master property to the tagger structure. > - Added the .tail_tag property to the tagger structure. > - Disabled "suppresscc = all" from my .gitconfig. Series applied, thank you.