* [PATCH v2 1/2] bus: mhi: Remove auto-start option
@ 2020-09-21 7:43 Loic Poulain
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Loic Poulain @ 2020-09-21 7:43 UTC (permalink / raw)
To: manivannan.sadhasivam, hemantk, davem
Cc: netdev, linux-arm-msm, bjorn.andersson, Loic Poulain
There is really no point having an auto-start for channels.
This is confusing for the device drivers, some have to enable the
channels, others don't have... and waste resources (e.g. pre allocated
buffers) that may never be used.
This is really up to the MHI device(channel) driver to manage the state
of its channels.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
v2: split MHI and qrtr changes in dedicated commits
drivers/bus/mhi/core/init.c | 9 ---------
drivers/bus/mhi/core/internal.h | 1 -
include/linux/mhi.h | 2 --
3 files changed, 12 deletions(-)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index dccc824..8798deb 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
mhi_chan->offload_ch = ch_cfg->offload_channel;
mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
mhi_chan->pre_alloc = ch_cfg->auto_queue;
- mhi_chan->auto_start = ch_cfg->auto_start;
/*
* If MHI host allocates buffers, then the channel direction
@@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
goto exit_probe;
ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
- if (ul_chan->auto_start) {
- ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
- if (ret)
- goto exit_probe;
- }
}
ret = -EINVAL;
@@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
if (ret)
goto exit_probe;
- if (dl_chan && dl_chan->auto_start)
- mhi_prepare_channel(mhi_cntrl, dl_chan);
-
mhi_device_put(mhi_dev);
return ret;
diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
index 5a81a42..73b52a0 100644
--- a/drivers/bus/mhi/core/internal.h
+++ b/drivers/bus/mhi/core/internal.h
@@ -563,7 +563,6 @@ struct mhi_chan {
bool configured;
bool offload_ch;
bool pre_alloc;
- bool auto_start;
bool wake_capable;
};
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index 811e686..0d277c7 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
* @offload_channel: The client manages the channel completely
* @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition
* @auto_queue: Framework will automatically queue buffers for DL traffic
- * @auto_start: Automatically start (open) this channel
* @wake-capable: Channel capable of waking up the system
*/
struct mhi_channel_config {
@@ -232,7 +231,6 @@ struct mhi_channel_config {
bool offload_channel;
bool doorbell_mode_switch;
bool auto_queue;
- bool auto_start;
bool wake_capable;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] net: qrtr: Start MHI channels during init
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
@ 2020-09-21 7:43 ` Loic Poulain
2020-09-26 7:56 ` Manivannan Sadhasivam
` (2 more replies)
2020-09-21 14:20 ` [PATCH v2 1/2] bus: mhi: Remove auto-start option Manivannan Sadhasivam
` (4 subsequent siblings)
5 siblings, 3 replies; 11+ messages in thread
From: Loic Poulain @ 2020-09-21 7:43 UTC (permalink / raw)
To: manivannan.sadhasivam, hemantk, davem
Cc: netdev, linux-arm-msm, bjorn.andersson, Loic Poulain
Start MHI device channels so that transfers can be performed.
The MHI stack does not auto-start channels anymore.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
v2: split MHI and qrtr changes in dedicated commits
net/qrtr/mhi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
index ff0c414..7100f0b 100644
--- a/net/qrtr/mhi.c
+++ b/net/qrtr/mhi.c
@@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
struct qrtr_mhi_dev *qdev;
int rc;
+ /* start channels */
+ rc = mhi_prepare_for_transfer(mhi_dev);
+ if (rc)
+ return rc;
+
qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
if (!qdev)
return -ENOMEM;
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] bus: mhi: Remove auto-start option
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
@ 2020-09-21 14:20 ` Manivannan Sadhasivam
2020-09-21 18:42 ` bbhatt
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-21 14:20 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
I need to hold this series for next merge window as this has the dependency
with ath11k driver and I'm not sure about the networking tree's merge window.
I'll merge this one and post patches to remove auto_start from ath11k mhi
driver for v5.11.
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> 3 files changed, 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index dccc824..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 811e686..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition
> * @auto_queue: Framework will automatically queue buffers for DL traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] bus: mhi: Remove auto-start option
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
2020-09-21 14:20 ` [PATCH v2 1/2] bus: mhi: Remove auto-start option Manivannan Sadhasivam
@ 2020-09-21 18:42 ` bbhatt
2020-09-26 8:00 ` Manivannan Sadhasivam
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: bbhatt @ 2020-09-21 18:42 UTC (permalink / raw)
To: Loic Poulain, clew
Cc: manivannan.sadhasivam, hemantk, davem, netdev, linux-arm-msm,
bjorn.andersson
On 2020-09-21 00:43, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> 3 files changed, 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index dccc824..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller
> *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h
> b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 811e686..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0
> transition
> * @auto_queue: Framework will automatically queue buffers for DL
> traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
Chris, are you OK with this? It will change the current behavior where
MHI will
not start the up link channel before providing QRTR with a probe.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] net: qrtr: Start MHI channels during init
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
@ 2020-09-26 7:56 ` Manivannan Sadhasivam
2020-09-26 19:32 ` David Miller
2020-09-27 3:02 ` Manivannan Sadhasivam
2020-11-16 5:22 ` Manivannan Sadhasivam
2 siblings, 1 reply; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-26 7:56 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
> Start MHI device channels so that transfers can be performed.
> The MHI stack does not auto-start channels anymore.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Dave: I'd like to queue this patch through MHI tree because there is a dependent
change in MHI bus. So, can you please provide your Ack?
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> net/qrtr/mhi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
> index ff0c414..7100f0b 100644
> --- a/net/qrtr/mhi.c
> +++ b/net/qrtr/mhi.c
> @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> struct qrtr_mhi_dev *qdev;
> int rc;
>
> + /* start channels */
> + rc = mhi_prepare_for_transfer(mhi_dev);
> + if (rc)
> + return rc;
> +
> qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
> if (!qdev)
> return -ENOMEM;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] bus: mhi: Remove auto-start option
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
` (2 preceding siblings ...)
2020-09-21 18:42 ` bbhatt
@ 2020-09-26 8:00 ` Manivannan Sadhasivam
2020-09-27 3:01 ` Manivannan Sadhasivam
2020-11-16 5:21 ` Manivannan Sadhasivam
5 siblings, 0 replies; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-26 8:00 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> 3 files changed, 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index dccc824..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 811e686..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition
> * @auto_queue: Framework will automatically queue buffers for DL traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] net: qrtr: Start MHI channels during init
2020-09-26 7:56 ` Manivannan Sadhasivam
@ 2020-09-26 19:32 ` David Miller
0 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2020-09-26 19:32 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: loic.poulain, hemantk, netdev, linux-arm-msm, bjorn.andersson
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date: Sat, 26 Sep 2020 13:26:56 +0530
> On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
>> Start MHI device channels so that transfers can be performed.
>> The MHI stack does not auto-start channels anymore.
>>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Dave: I'd like to queue this patch through MHI tree because there is a dependent
> change in MHI bus. So, can you please provide your Ack?
Sure:
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] bus: mhi: Remove auto-start option
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
` (3 preceding siblings ...)
2020-09-26 8:00 ` Manivannan Sadhasivam
@ 2020-09-27 3:01 ` Manivannan Sadhasivam
2020-11-16 5:21 ` Manivannan Sadhasivam
5 siblings, 0 replies; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-27 3:01 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> 3 files changed, 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index dccc824..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 811e686..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition
> * @auto_queue: Framework will automatically queue buffers for DL traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] net: qrtr: Start MHI channels during init
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
2020-09-26 7:56 ` Manivannan Sadhasivam
@ 2020-09-27 3:02 ` Manivannan Sadhasivam
2020-11-16 5:22 ` Manivannan Sadhasivam
2 siblings, 0 replies; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-27 3:02 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
> Start MHI device channels so that transfers can be performed.
> The MHI stack does not auto-start channels anymore.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> net/qrtr/mhi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
> index ff0c414..7100f0b 100644
> --- a/net/qrtr/mhi.c
> +++ b/net/qrtr/mhi.c
> @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> struct qrtr_mhi_dev *qdev;
> int rc;
>
> + /* start channels */
> + rc = mhi_prepare_for_transfer(mhi_dev);
> + if (rc)
> + return rc;
> +
> qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
> if (!qdev)
> return -ENOMEM;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] bus: mhi: Remove auto-start option
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
` (4 preceding siblings ...)
2020-09-27 3:01 ` Manivannan Sadhasivam
@ 2020-11-16 5:21 ` Manivannan Sadhasivam
5 siblings, 0 replies; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-16 5:21 UTC (permalink / raw)
To: Loic Poulain
Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson, ath11k
+ath11k list
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-ath11k-immutable branch! This branch will get merged into
mhi-next and ath-next.
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> 3 files changed, 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index dccc824..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 811e686..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition
> * @auto_queue: Framework will automatically queue buffers for DL traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] net: qrtr: Start MHI channels during init
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
2020-09-26 7:56 ` Manivannan Sadhasivam
2020-09-27 3:02 ` Manivannan Sadhasivam
@ 2020-11-16 5:22 ` Manivannan Sadhasivam
2 siblings, 0 replies; 11+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-16 5:22 UTC (permalink / raw)
To: Loic Poulain
Cc: hemantk, davem, netdev, linux-arm-msm, bjorn.andersson, ath11k
+ath11k list
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote:
> Start MHI device channels so that transfers can be performed.
> The MHI stack does not auto-start channels anymore.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-ath11k-immutable branch! This branch will get merged into
mhi-next and ath-next.
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> net/qrtr/mhi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
> index ff0c414..7100f0b 100644
> --- a/net/qrtr/mhi.c
> +++ b/net/qrtr/mhi.c
> @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> struct qrtr_mhi_dev *qdev;
> int rc;
>
> + /* start channels */
> + rc = mhi_prepare_for_transfer(mhi_dev);
> + if (rc)
> + return rc;
> +
> qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
> if (!qdev)
> return -ENOMEM;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-11-16 5:23 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
2020-09-26 7:56 ` Manivannan Sadhasivam
2020-09-26 19:32 ` David Miller
2020-09-27 3:02 ` Manivannan Sadhasivam
2020-11-16 5:22 ` Manivannan Sadhasivam
2020-09-21 14:20 ` [PATCH v2 1/2] bus: mhi: Remove auto-start option Manivannan Sadhasivam
2020-09-21 18:42 ` bbhatt
2020-09-26 8:00 ` Manivannan Sadhasivam
2020-09-27 3:01 ` Manivannan Sadhasivam
2020-11-16 5:21 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).