From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: jishi@redhat.com, kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ip6gre: avoid tx_error when sending MLD/DAD on external tunnels
Date: Mon, 28 Sep 2020 16:01:54 -0700 (PDT) [thread overview]
Message-ID: <20200928.160154.653590366401035900.davem@davemloft.net> (raw)
In-Reply-To: <e63a72579b88602442650ba38764c0beeed05ada.1601215294.git.dcaratti@redhat.com>
From: Davide Caratti <dcaratti@redhat.com>
Date: Sun, 27 Sep 2020 16:08:21 +0200
> similarly to what has been done with commit 9d149045b3c0 ("geneve: change
> from tx_error to tx_dropped on missing metadata"), avoid reporting errors
> to userspace in case the kernel doesn't find any tunnel information for a
> skb that is going to be transmitted: an increase of tx_dropped is enough.
>
> tested with the following script:
>
> # for t in ip6gre ip6gretap ip6erspan; do
> > ip link add dev gre6-test0 type $t external
> > ip address add dev gre6-test0 2001:db8::1/64
> > ip link set dev gre6-test0 up
> > sleep 30
> > ip -s -j link show dev gre6-test0 | jq \
> > '.[0].stats64.tx | {"errors": .errors, "dropped": .dropped}'
> > ip link del dev gre6-test0
> > done
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Applied.
prev parent reply other threads:[~2020-09-28 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 14:08 [PATCH net-next] ip6gre: avoid tx_error when sending MLD/DAD on external tunnels Davide Caratti
2020-09-28 23:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928.160154.653590366401035900.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jishi@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).