From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49F3C2D0A8 for ; Mon, 28 Sep 2020 23:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63899208FE for ; Mon, 28 Sep 2020 23:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601337032; bh=Q1WadYaHJ/iF7WoRE+yG6pgPkhBXH0g+s8ULMV8zjv4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=dpiuHWoqgIGOzuF61E9zs0+NugN0f+NYj63a7xua8FTc/fLTrfihQOlvYy2aPslDy QUKdWBM7q5D2X/BDfIhxpD7rkFShmCB/AGyktfTBCynYi5t8Y1iPy6JV9ZAJd9AGpV BjKtyW2xZuJRe7++gpe2LPw2JuxPcIV2aHUwsD/8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgI1Xub (ORCPT ); Mon, 28 Sep 2020 19:50:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:46346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgI1Xub (ORCPT ); Mon, 28 Sep 2020 19:50:31 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6459F23A34; Mon, 28 Sep 2020 22:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601332506; bh=Q1WadYaHJ/iF7WoRE+yG6pgPkhBXH0g+s8ULMV8zjv4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m6m4OmEL9z+5+99rhf/8yVUzO02n8U/ZrcJKvkitKOHTTG58fW1666lNBzWyE+Wzn SZQsmOrMO7aZxysHX8covLcWyQTQKimHSyV0xk6FHniEMcTClffqZYZqNecVSgGzQU Mtfh++Q186pnYFvvqqR2Opxi3M62BXtoGZ6GtZxs= Date: Mon, 28 Sep 2020 15:35:04 -0700 From: Jakub Kicinski To: Andrew Lunn Cc: Vladimir Oltean , David Miller , netdev , Florian Fainelli , Jiri Pirko Subject: Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour Message-ID: <20200928153504.1b39a65d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200928220730.GD3950513@lunn.ch> References: <20200926210632.3888886-1-andrew@lunn.ch> <20200926210632.3888886-2-andrew@lunn.ch> <20200928143155.4b12419d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200928220507.olh77t464bqsc4ll@skbuf> <20200928220730.GD3950513@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 29 Sep 2020 00:07:30 +0200 Andrew Lunn wrote: > On Mon, Sep 28, 2020 at 10:05:08PM +0000, Vladimir Oltean wrote: > > On Mon, Sep 28, 2020 at 02:31:55PM -0700, Jakub Kicinski wrote: > > > On Sat, 26 Sep 2020 23:06:26 +0200 Andrew Lunn wrote: > > > > Not all ports of a switch need to be used, particularly in embedded > > > > systems. Add a port flavour for ports which physically exist in the > > > > switch, but are not connected to the front panel etc, and so are > > > > unused. > > > > > > This is missing the explanation of why reporting such ports makes sense. > > > > Because this is a core devlink patch, we're talking really generalistic > > here. > > Hi Vladimir > > I don't think Jakub is questioning the why. He just wants it in the > commit message. Ack, I think we need to clearly say when those should be exposed. Most ASICs will have disabled ports, and we don't expect NICs to suddenly start reporting ports for all PCI PFs they may have. Also I keep thinking that these ports and all their objects should be hidden under some switch from user space perspective because they are unlikely to be valuable to see for a normal user. Thoughts?