From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: ioana.ciornei@nxp.com, ruxandra.radulescu@nxp.com,
kuba@kernel.org, andrew@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] dpaa2-mac: Fix potential null pointer dereference
Date: Tue, 29 Sep 2020 08:14:37 -0500 [thread overview]
Message-ID: <20200929131437.GB28922@embeddedor> (raw)
In-Reply-To: <20200925.171554.1696394343282908508.davem@davemloft.net>
On Fri, Sep 25, 2020 at 05:15:54PM -0700, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Date: Fri, 25 Sep 2020 12:03:23 -0500
>
> > There is a null-check for _pcs_, but it is being dereferenced
> > prior to this null-check. So, if _pcs_ can actually be null,
> > then there is a potential null pointer dereference that should
> > be fixed by null-checking _pcs_ before being dereferenced.
> >
> > Addresses-Coverity-ID: 1497159 ("Dereference before null check")
> > Fixes: 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Applied, thanks.
Thanks, Dave.
--
Gustavo
prev parent reply other threads:[~2020-09-29 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 17:03 [PATCH][next] dpaa2-mac: Fix potential null pointer dereference Gustavo A. R. Silva
2020-09-26 0:15 ` David Miller
2020-09-29 13:14 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929131437.GB28922@embeddedor \
--to=gustavoars@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).