From: Jiri Pirko <jiri@resnulli.us>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v2 1/7] net: devlink: Add unused port flavour
Date: Wed, 30 Sep 2020 16:34:52 +0200 [thread overview]
Message-ID: <20200930143452.GJ8264@nanopsycho> (raw)
In-Reply-To: <20200930135725.GH3996795@lunn.ch>
Wed, Sep 30, 2020 at 03:57:25PM CEST, andrew@lunn.ch wrote:
>> I get it. But I as I wrote previously, I wonder if used/unused should
>> not be another attribute. Then the flavour can be "undefined".
>
>In the DSA world, it is not undefined. It is clear defined as
>unused. And it cannot be on-the-fly changed. It is a property of the
>PCB, in that the pins exist on the chip, but they simply don't go
>anywhere on the PCB. This is quite common on appliances, e.g. The
>switch has 7 ports, but the installation in the aircraft is a big
>ring, so there is a 'left', 'right', 'aux' and the CPU port. That
>leaves 3 ports totally unused.
Understand the DSA usecase.
>
>> But, why do you want to show "unused" ports? Can the user do something
>> with them? What is the value in showing them?
>
>Because they are just ports, they can have regions. We can look at the
What do you mean by "regions"? Devlink regions? They are per-device, not
per-port. I have to be missing something.
>region and be sure they are powered off, the boot loader etc has not
>left them in a funny state, bridged to other ports, etc.
It is driver's responsibility to ensure that. But that does not mean
that the devlink port needs to be visible.
>
>Regions are a developers tool, not a 'user' tools. So the idea of
>hiding them by default in 'devlink port show' does make some sense,
>and have a flag like -d for details, which includes them. In 'devlink
>region show' i would probably list all regions, independent of any -d
>flag.
>
> Andrew
next prev parent reply other threads:[~2020-09-30 14:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 21:06 [PATCH net-next v2 0/7] mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 1/7] net: devlink: Add unused port flavour Andrew Lunn
2020-09-26 21:51 ` Vladimir Oltean
2020-09-26 22:00 ` Vladimir Oltean
2020-09-27 0:33 ` Andrew Lunn
2020-09-28 21:31 ` Jakub Kicinski
2020-09-28 22:05 ` Vladimir Oltean
2020-09-28 22:07 ` Andrew Lunn
2020-09-28 22:35 ` Jakub Kicinski
2020-09-28 22:36 ` Florian Fainelli
2020-09-28 23:39 ` Jakub Kicinski
2020-09-29 1:46 ` Florian Fainelli
2020-09-29 11:03 ` Vladimir Oltean
2020-09-29 13:07 ` Jiri Pirko
2020-09-29 13:48 ` Vladimir Oltean
2020-09-29 15:12 ` Jiri Pirko
2020-09-29 13:57 ` Andrew Lunn
2020-09-30 6:56 ` Jiri Pirko
2020-09-30 13:57 ` Andrew Lunn
2020-09-30 14:34 ` Jiri Pirko [this message]
2020-09-30 14:53 ` Andrew Lunn
2020-10-01 7:39 ` Jiri Pirko
2020-09-26 21:06 ` [PATCH net-next v2 2/7] net: dsa: Make use of devlink port flavour unused Andrew Lunn
2020-09-26 22:51 ` Vladimir Oltean
2020-09-26 21:06 ` [PATCH net-next v2 3/7] net: dsa: Register devlink ports before calling DSA driver setup() Andrew Lunn
2020-09-26 23:37 ` Vladimir Oltean
2020-09-27 0:45 ` Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 4/7] net: devlink: Add support for port regions Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 5/7] net: dsa: Add devlink port regions support to DSA Andrew Lunn
2020-09-26 23:42 ` Vladimir Oltean
2020-09-26 21:06 ` [PATCH net-next v2 6/7] net: dsa: Add helper for converting devlink port to ds and port Andrew Lunn
2020-09-26 21:06 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: Add per port devlink regions Andrew Lunn
2020-09-26 23:52 ` Vladimir Oltean
2020-09-27 1:03 ` Andrew Lunn
2020-09-27 1:11 ` Vladimir Oltean
2020-09-26 22:02 ` [PATCH net-next v2 0/7] " Marek Behun
2020-09-26 22:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930143452.GJ8264@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).