From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH 2/2] netlink: export policy in extended ACK
Date: Tue, 6 Oct 2020 09:16:44 -0700 [thread overview]
Message-ID: <20201006091644.0425e0fe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <0f534e06a9b2248cc4a5ae941caf7772a864a68f.camel@sipsolutions.net>
On Tue, 06 Oct 2020 17:10:44 +0200 Johannes Berg wrote:
> Sorry, hat to run out earlier and forgot to comment here.
>
> On Tue, 2020-10-06 at 14:32 +0200, Johannes Berg wrote:
> >
> > + /* the max policy content is currently ~44 bytes for range min/max */
> > + if (err && nlk_has_extack && extack && extack->policy)
> > + tlvlen += 64;
>
> So I'm not really happy with this. I counted 44 bytes content (so 48
> bytes for the nested attribute) for the biggest that we have now, but if
> we ever implement e.g. dumping out the reject string for NLA_REJECT
> (though not sure anyone even uses that?) then it'd be more variable.
I wonder if we should in fact dump the reject string, in this case it
feels like an omission not to have it... although as you say, grep for
reject_message reveals it's completely unused today.
> I couldn't really come up with any better idea, but I believe we do need
> to size the skb fairly well to return the original one ...
>
> The only solution I _could_ think of was to allocate another skb, put
> the attribute into it, check the length, and then later append it to the
> message ... but that seemed kinda ugly.
>
> Any preferences?
It'd feel pretty idiomatic for (rt)netlink to have
netlink_policy_dump_attr_size()
which would calculate the size. That'd cost us probably ~100 LoC?
If that's too much we could at least add a define for this constant,
and WARN_ON_ONCE() in __netlink_policy_dump_write_attr() if the dump
ends up larger?
next prev parent reply other threads:[~2020-10-06 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 12:32 [PATCH 0/2] netlink: export policy on validation failures Johannes Berg
2020-10-06 12:32 ` [PATCH 1/2] netlink: policy: refactor per-attr policy writing Johannes Berg
2020-10-06 12:32 ` [PATCH 2/2] netlink: export policy in extended ACK Johannes Berg
2020-10-06 15:10 ` Johannes Berg
2020-10-06 16:16 ` Jakub Kicinski [this message]
2020-10-06 17:31 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006091644.0425e0fe@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=dsahern@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).