From: Vladimir Oltean <olteanv@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>,
ilias.apalodimas@linaro.org
Subject: Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches
Date: Tue, 6 Oct 2020 15:37:05 +0300 [thread overview]
Message-ID: <20201006123705.bnrborrpms6vaegz@skbuf> (raw)
In-Reply-To: <20201006113237.73rzvw34anilqh4d@skbuf>
On Tue, Oct 06, 2020 at 02:32:37PM +0300, Vladimir Oltean wrote:
> - The .port_vlan_add will always install the VLAN to the hardware
> database, no queuing if there's no reason for it (and I can't see any.
> Your hardware seems to be sane enough to not drop a VLAN-tagged frame,
> and forward it correctly on egress, as long as you call
> hellcreek_setup_ingressflt with enable=false, am I right? or does the
> VLAN still need to be installed into the egress port?).
I don't know if this goes without saying or not, but of course, if you
can't enforce correct behavior with a vlan_filtering=0 bridge (i.e.
"ingressflt" will only help the VLAN-tagged frames to be accepted on
ingress, but they will be nonetheless dropped on egress due to no valid
destinations), then you should reject that setting in the 2 places where
vlan_filtering can be enabled:
(a) in .port_prechangeupper, you should make sure that if the upper is a
bridge, then br_vlan_enabled() must be true.
(b) in .port_vlan_filtering, you should reject enabled=false from the
switchdev_trans_ph_prepare(trans) state.
Again, this isn't about implementing every possible combination, just
about making sure that the user isn't led into believing that a certain
setting works when in reality it doesn't.
> @@ -2006,10 +2006,22 @@ static int dsa_slave_netdevice_event(struct notifier_block *nb,
> switch (event) {
> case NETDEV_PRECHANGEUPPER: {
> struct netdev_notifier_changeupper_info *info = ptr;
> + struct dsa_switch *ds;
> + struct dsa_port *dp;
> + int err;
>
> if (!dsa_slave_dev_check(dev))
> return dsa_prevent_bridging_8021q_upper(dev, ptr);
>
> + dp = dsa_slave_to_port(dev);
> + ds = dp->ds;
> +
> + if (ds->ops->port_prechangeupper) {
> + err = ds->ops->port_prechangeupper(ds, dp->index, ptr);
> + if (err)
> + return err;
Correction: this should return notifier_from_errno(err).
> + }
> +
> if (is_vlan_dev(info->upper_dev))
> return dsa_slave_check_8021q_upper(dev, ptr);
> break;
> --
> 2.25.1
next prev parent reply other threads:[~2020-10-06 12:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 11:29 [PATCH net-next v6 0/7] Hirschmann Hellcreek DSA driver Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches Kurt Kanzenbach
2020-10-04 11:56 ` Vladimir Oltean
2020-10-05 6:14 ` Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 2/7] net: dsa: Add DSA driver " Kurt Kanzenbach
2020-10-04 12:56 ` Vladimir Oltean
2020-10-06 6:09 ` Kurt Kanzenbach
2020-10-06 9:20 ` Vladimir Oltean
2020-10-06 10:13 ` Kurt Kanzenbach
2020-10-06 11:32 ` Vladimir Oltean
2020-10-06 12:37 ` Vladimir Oltean [this message]
2020-10-06 13:23 ` Kurt Kanzenbach
2020-10-06 13:42 ` Vladimir Oltean
2020-10-06 14:05 ` Kurt Kanzenbach
2020-10-06 14:10 ` Vladimir Oltean
2020-10-06 13:56 ` Vladimir Oltean
2020-10-06 14:13 ` Kurt Kanzenbach
2020-10-11 12:29 ` Kurt Kanzenbach
2020-10-11 15:30 ` Vladimir Oltean
2020-10-12 5:37 ` Kurt Kanzenbach
2020-10-16 12:11 ` Kurt Kanzenbach
2020-10-16 15:43 ` Vladimir Oltean
2020-10-16 16:56 ` Florian Fainelli
2020-10-17 10:06 ` Kurt Kanzenbach
2020-10-17 15:57 ` Vladimir Oltean
2020-10-08 11:49 ` Vladimir Oltean
2020-10-09 5:58 ` Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 3/7] net: dsa: hellcreek: Add PTP clock support Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping Kurt Kanzenbach
2020-10-04 14:30 ` Vladimir Oltean
2020-10-06 6:27 ` Kurt Kanzenbach
2020-10-06 7:28 ` Vladimir Oltean
2020-10-06 13:30 ` Kurt Kanzenbach
2020-10-06 13:32 ` Vladimir Oltean
2020-10-06 13:56 ` Kurt Kanzenbach
2020-10-06 14:01 ` Vladimir Oltean
2020-10-07 10:39 ` Kurt Kanzenbach
2020-10-07 10:54 ` Vladimir Oltean
2020-10-08 8:34 ` Kurt Kanzenbach
2020-10-08 9:44 ` Vladimir Oltean
2020-10-08 10:01 ` Kurt Kanzenbach
2020-10-08 12:55 ` Kamil Alkhouri
2020-10-08 15:09 ` Vladimir Oltean
2020-10-12 12:53 ` Kamil Alkhouri
2020-10-12 21:42 ` Richard Cochran
2020-10-14 9:57 ` Vladimir Oltean
2020-10-14 11:01 ` Richard Cochran
2020-10-14 11:37 ` Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 5/7] net: dsa: hellcreek: Add PTP status LEDs Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 6/7] dt-bindings: Add vendor prefix for Hirschmann Kurt Kanzenbach
2020-10-04 11:29 ` [PATCH net-next v6 7/7] dt-bindings: net: dsa: Add documentation for Hellcreek switches Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006123705.bnrborrpms6vaegz@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kamil.alkhouri@hs-offenburg.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).