* [PATCH net-next] ne2k-pci: Enable RW-Bugfix
@ 2020-10-06 16:56 Armin Wolf
2020-10-09 1:01 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Armin Wolf @ 2020-10-06 16:56 UTC (permalink / raw)
To: davem; +Cc: netdev
Enable the ne2k-pci Read-before-Write Bugfix
since not doing so could (according to the Datasheet)
cause the system to lock up with some chips.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
index bc6edb3f1af3..a1319cd86ab9 100644
--- a/drivers/net/ethernet/8390/ne2k-pci.c
+++ b/drivers/net/ethernet/8390/ne2k-pci.c
@@ -91,7 +91,7 @@ MODULE_PARM_DESC(full_duplex, "full duplex setting(s) (1)");
#define USE_LONGIO
/* Do we implement the read before write bugfix ? */
-/* #define NE_RW_BUGFIX */
+#define NE_RW_BUGFIX
/* Flags. We rename an existing ei_status field to store flags!
* Thus only the low 8 bits are usable for non-init-time flags.
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ne2k-pci: Enable RW-Bugfix
2020-10-06 16:56 [PATCH net-next] ne2k-pci: Enable RW-Bugfix Armin Wolf
@ 2020-10-09 1:01 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-09 1:01 UTC (permalink / raw)
To: Armin Wolf; +Cc: davem, netdev
On Tue, 6 Oct 2020 18:56:06 +0200 Armin Wolf wrote:
> Enable the ne2k-pci Read-before-Write Bugfix
> since not doing so could (according to the Datasheet)
> cause the system to lock up with some chips.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
> index bc6edb3f1af3..a1319cd86ab9 100644
> --- a/drivers/net/ethernet/8390/ne2k-pci.c
> +++ b/drivers/net/ethernet/8390/ne2k-pci.c
> @@ -91,7 +91,7 @@ MODULE_PARM_DESC(full_duplex, "full duplex setting(s) (1)");
> #define USE_LONGIO
>
> /* Do we implement the read before write bugfix ? */
> -/* #define NE_RW_BUGFIX */
> +#define NE_RW_BUGFIX
This doesn't do anything, does it:
$ git grep NE_RW_BUGFIX
drivers/net/ethernet/8390/ne.c:/* #define NE_RW_BUGFIX */
drivers/net/ethernet/8390/ne2k-pci.c:/* #define NE_RW_BUGFIX */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-09 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 16:56 [PATCH net-next] ne2k-pci: Enable RW-Bugfix Armin Wolf
2020-10-09 1:01 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).