From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98EE1C41604 for ; Wed, 7 Oct 2020 17:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AA1D21707 for ; Wed, 7 Oct 2020 17:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602090394; bh=CLekkomzfrCOSQyfgDJ4AsbNaDHOlGZN87kfejQlUnU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QJzYZlxOPnN0kxnkOgDvWFh89/EvbSAXNjyEIOjK2Q+RPdhUjkd4dFQkUejOVq+iK Lgv3U9ZBHVnsyvEOcn4MR+t8gfBA21rby1WDvo7a8fPIwINJB4IJ2JVTZ09NrfxLdG 7p6EnSAGR/7Y6pufP2ma5yyaJlH8fzb+GGMvqJMQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727999AbgJGRGd (ORCPT ); Wed, 7 Oct 2020 13:06:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:53738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727678AbgJGRGd (ORCPT ); Wed, 7 Oct 2020 13:06:33 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 691A621582; Wed, 7 Oct 2020 17:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602090392; bh=CLekkomzfrCOSQyfgDJ4AsbNaDHOlGZN87kfejQlUnU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gW4N4p4eM07y9a/YyzN3Faxx8JDYue5JAXKzNEXW+Kzpdn01Hi21vdUHe9IxQ0sl3 EaiKby7BuggY4GdjOd2KYUFIQzm8ITe19se9+wF1jp0wuZlDYsu3QsXsERBwv+UQfX yL+XTrCDX3vRvyi+SntWZLL87BEsQy06i+ZbEJoM= Date: Wed, 7 Oct 2020 10:06:30 -0700 From: Jakub Kicinski To: Johannes Berg Cc: netdev@vger.kernel.org, dsahern@gmail.com, Johannes Berg Subject: Re: [PATCH v2 1/2] netlink: policy: refactor per-attr policy writing Message-ID: <20201007100630.396f573c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201006201333.8ab12687d931.Id092e96bbd4df7102eea602baf20a409bff3b9b0@changeid> References: <20201006181555.103140-1-johannes@sipsolutions.net> <20201006201333.8ab12687d931.Id092e96bbd4df7102eea602baf20a409bff3b9b0@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 6 Oct 2020 20:15:54 +0200 Johannes Berg wrote: > + const struct nla_policy *pt; > + struct nlattr *policy; > + int err; > + bool again; nit: rev-xmas tree