From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=kY2t=DP=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 084B8C433E7
	for <netdev@archiver.kernel.org>; Thu,  8 Oct 2020 16:14:46 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id A2C9E21D7D
	for <netdev@archiver.kernel.org>; Thu,  8 Oct 2020 16:14:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1602173685;
	bh=bM5ahj/gZtgfxTO4eposlFzm3ykzO1VrYEGMdCeVYRo=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=Dl7S+7yhM/F+0jVAanIw2C6hWVIj2QNYit84pPkg3GfOIZuS1hEbj5fTIDmkLEKD0
	 H2WRdl2+KJ0v72Iw4zEOLlVeiXS3s+Ho05WurcNBGKm2BaPKEnCSwArm1VGJS6eN+u
	 woFBjZm1OutX0JWt0d3EJTfXkiBx5zEAolPo683g=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730844AbgJHQOn (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 8 Oct 2020 12:14:43 -0400
Received: from mail.kernel.org ([198.145.29.99]:47838 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728859AbgJHQOm (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 8 Oct 2020 12:14:42 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id BF3A921D7D;
        Thu,  8 Oct 2020 16:14:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1602173682;
        bh=bM5ahj/gZtgfxTO4eposlFzm3ykzO1VrYEGMdCeVYRo=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=wf3lejOgfjnGnsAPppAmjMDRpgg4mrzVgyTL4Cy+D+0EqNyCp+qpZ1LQ7KPJDDaeG
         9bFqO5vZ4qd4BP23qUuogOMXKHaLs87uDWeSNOxOtCg/i+z0vfcnVTv3rTYGwaRm3a
         xgujHiK9uXxDS9AbH8Du7kEICyCNFEy+4ESTyQIA=
Date:   Thu, 8 Oct 2020 09:14:37 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [net-next PATCH v3] net: dsa: rtl8366rb: Roof MTU for switch
Message-ID: <20201008091437.559e3d6c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201008091955.44692-1-linus.walleij@linaro.org>
References: <20201008091955.44692-1-linus.walleij@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu,  8 Oct 2020 11:19:55 +0200 Linus Walleij wrote:
> diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
> index 053bf5041f8d..28f510a580be 100644
> --- a/drivers/net/dsa/rtl8366rb.c
> +++ b/drivers/net/dsa/rtl8366rb.c
> @@ -311,6 +311,13 @@
>  #define RTL8366RB_GREEN_FEATURE_TX	BIT(0)
>  #define RTL8366RB_GREEN_FEATURE_RX	BIT(2)
>  
> +/**
> + * struct rtl8366rb - RTL8366RB-specific data
> + */
> +struct rtl8366rb {
> +	unsigned int max_mtu[RTL8366RB_NUM_PORTS];
> +};

If you make the comment kdoc, you gotta describe all fields (or mark
'em private) otherwise:

drivers/net/dsa/rtl8366rb.c:319: warning: Function parameter or member 'max_mtu' not described in 'rtl8366rb'