From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C6FC43467 for ; Fri, 9 Oct 2020 00:19:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C31C222253 for ; Fri, 9 Oct 2020 00:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602202783; bh=QHP0V82CfbIX8o7dz0rRle4Ax0kv0c4cLYCcYhOkf7M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=phs3HADfFvbUwPYAqOzL9DUYqEIdrx7x+jOB9cEyPWUKH/VJdrgciG5ksccGmZ+7o 4XgKWk/u9DEfAP18jKeTw1IdXGHXSaETuJdaEy9pJFEoxsGIk8EB25CkmWCoIz/ALz R4OoNauUggYGObuEMR835GPViqKQiAC6f4jbbJko= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731203AbgJIATm (ORCPT ); Thu, 8 Oct 2020 20:19:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:59586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725952AbgJIASs (ORCPT ); Thu, 8 Oct 2020 20:18:48 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2707D22253; Fri, 9 Oct 2020 00:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602202728; bh=QHP0V82CfbIX8o7dz0rRle4Ax0kv0c4cLYCcYhOkf7M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VCJN9uQdYINwvVBfn9esTIYjg1ypxqp9hxQM6fZs161/3dAktPxA5uBwiE35kuTaw wIskjCjIhMVivzeDB2pqJJcLSmDeTQAouwa6BYJ7t8Xuc2Hd4YmUXlQjLIRgOovMJi fHuHyQlI1d3pKxStox4/6DAkg8JlQtxrESlHNJ7I= Date: Thu, 8 Oct 2020 17:18:46 -0700 From: Jakub Kicinski To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Cong Wang , Allen Pais Subject: Re: [PATCH net-next] net/sched: get rid of qdisc->padded Message-ID: <20201008171846.335b435a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201007165111.172419-1-eric.dumazet@gmail.com> References: <20201007165111.172419-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote: > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index 6c762457122fd0091cb0f2bf41bda73babc4ac12..d8fd8676fc724110630904909f64d7789f3a4b47 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @@ -91,7 +91,7 @@ struct Qdisc { > struct net_rate_estimator __rcu *rate_est; > struct gnet_stats_basic_cpu __percpu *cpu_bstats; > struct gnet_stats_queue __percpu *cpu_qstats; > - int padded; > + int pad; > refcount_t refcnt; > > /* Hi Eric! Why keep the pad field? the member to lines down is __cacheline_aligned, so we shouldn't have to manually push things out? struct gnet_stats_queue __percpu *cpu_qstats; int pad; refcount_t refcnt; /* * For performance sake on SMP, we put highly modified fields at the end */ struct sk_buff_head gso_skb ____cacheline_aligned_in_smp;