From: Jakub Kicinski <kuba@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Richard Leitner <richard.leitner@skidata.com>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
"David S . Miller" <davem@davemloft.net>,
NXP Linux Team <linux-imx@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk_enable()
Date: Thu, 8 Oct 2020 17:51:24 -0700 [thread overview]
Message-ID: <20201008175124.08f3fe5e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201006135253.97395-1-marex@denx.de>
On Tue, 6 Oct 2020 15:52:53 +0200 Marek Vasut wrote:
> The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
> loses its register settings. The fec_enet_mii_probe() starts the PHY
> and does the necessary calls to configure the PHY via PHY framework,
> and loads the correct register settings into the PHY. Therefore,
> fec_enet_mii_probe() should be called only after the PHY has been
> reset, not before as it is now.
>
> Fixes: 1b0a83ac04e3 ("net: fec: add phy_reset_after_clk_enable() support")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Richard Leitner <richard.leitner@skidata.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
Is moving the reset before fec_enet_mii_probe() the reason you need the
second patch?
net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()
next prev parent reply other threads:[~2020-10-09 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 13:52 [PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk_enable() Marek Vasut
2020-10-09 0:51 ` Jakub Kicinski [this message]
2020-10-09 7:21 ` Marek Vasut
2020-10-09 15:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008175124.08f3fe5e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cniedermaier@dh-electronics.com \
--cc=davem@davemloft.net \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).