From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: davem@davemloft.net, alexandre.belloni@bootlin.com,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
Divya Koppera <Divya.Koppera@microchip.com>
Subject: Re: [PATCH net-next] net: mscc: ocelot: add missing VCAP ES0 and IS1 regmaps for VSC7514
Date: Thu, 8 Oct 2020 17:53:42 -0700 [thread overview]
Message-ID: <20201008175342.01ea014d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201006150248.1911469-1-vladimir.oltean@nxp.com>
On Tue, 6 Oct 2020 18:02:48 +0300 Vladimir Oltean wrote:
> Without these definitions, the driver will crash in:
> mscc_ocelot_probe
> -> ocelot_init
> -> ocelot_vcap_init
> -> __ocelot_target_read_ix
>
> I missed this because I did not have the VSC7514 hardware to test, only
> the VSC9959 and VSC9953, and the probing part is different.
>
> Fixes: e3aea296d86f ("net: mscc: ocelot: add definitions for VCAP ES0 keys, actions and target")
> Fixes: a61e365d7c18 ("net: mscc: ocelot: add definitions for VCAP IS1 keys, actions and target")
> Reported-by: Divya Koppera <Divya.Koppera@microchip.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied, thanks!
prev parent reply other threads:[~2020-10-09 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:02 [PATCH net-next] net: mscc: ocelot: add missing VCAP ES0 and IS1 regmaps for VSC7514 Vladimir Oltean
2020-10-09 0:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008175342.01ea014d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).