From: Jakub Kicinski <kuba@kernel.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ne2k-pci: Enable RW-Bugfix
Date: Thu, 8 Oct 2020 18:01:08 -0700 [thread overview]
Message-ID: <20201008180108.43e502a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201006165606.7313-1-W_Armin@gmx.de>
On Tue, 6 Oct 2020 18:56:06 +0200 Armin Wolf wrote:
> Enable the ne2k-pci Read-before-Write Bugfix
> since not doing so could (according to the Datasheet)
> cause the system to lock up with some chips.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
> index bc6edb3f1af3..a1319cd86ab9 100644
> --- a/drivers/net/ethernet/8390/ne2k-pci.c
> +++ b/drivers/net/ethernet/8390/ne2k-pci.c
> @@ -91,7 +91,7 @@ MODULE_PARM_DESC(full_duplex, "full duplex setting(s) (1)");
> #define USE_LONGIO
>
> /* Do we implement the read before write bugfix ? */
> -/* #define NE_RW_BUGFIX */
> +#define NE_RW_BUGFIX
This doesn't do anything, does it:
$ git grep NE_RW_BUGFIX
drivers/net/ethernet/8390/ne.c:/* #define NE_RW_BUGFIX */
drivers/net/ethernet/8390/ne2k-pci.c:/* #define NE_RW_BUGFIX */
prev parent reply other threads:[~2020-10-09 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 16:56 [PATCH net-next] ne2k-pci: Enable RW-Bugfix Armin Wolf
2020-10-09 1:01 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008180108.43e502a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=W_Armin@gmx.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).