From: Jakub Kicinski <kuba@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
"David S . Miller" <davem@davemloft.net>,
NXP Linux Team <linux-imx@nxp.com>,
Richard Leitner <richard.leitner@skidata.com>,
Shawn Guo <shawnguo@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()
Date: Fri, 9 Oct 2020 08:15:32 -0700 [thread overview]
Message-ID: <20201009081532.30411d62@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <da024643-e7bc-3470-64ad-96277655f494@denx.de>
On Fri, 9 Oct 2020 09:20:30 +0200 Marek Vasut wrote:
> > Can you describe your problem in detail?
>
> Yes, I tried to do that in the commit message and the extra detailed
> comment above the code. What exactly do you not understand from that?
Why it's not bound on the first open (I'm guessing it's the first open
that has the ndev->phydev == NULL? I shouldn't have to guess).
> > To an untrained eye this looks pretty weird.
>
> I see, I'm not quite sure how to address this comment.
If ndev->phydev sometimes is not-NULL on open, then that's a valid
state to be in. Why not make sure that we're always in that state
and can depend on ndev->phydev rather than rummaging around for
the phy_device instance.
next prev parent reply other threads:[~2020-10-09 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 20:20 [PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable() Marek Vasut
2020-10-06 21:09 ` Florian Fainelli
2020-10-06 22:02 ` Marek Vasut
2020-10-09 0:46 ` Jakub Kicinski
2020-10-09 7:20 ` Marek Vasut
2020-10-09 15:15 ` Jakub Kicinski [this message]
2020-10-09 17:34 ` Marek Vasut
2020-10-09 18:02 ` Jakub Kicinski
2020-10-10 8:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009081532.30411d62@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cniedermaier@dh-electronics.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).