netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Dmitry Yakunin <zeil@yandex-team.ru>
Cc: sharpd@nvidia.com, dsahern@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] lib: ignore invalid mounts in cg_init_map
Date: Sun, 11 Oct 2020 23:03:57 -0700	[thread overview]
Message-ID: <20201011230357.198aaa5e@hermes.local> (raw)
In-Reply-To: <20201008175927.47130-1-zeil@yandex-team.ru>

On Thu,  8 Oct 2020 20:59:27 +0300
Dmitry Yakunin <zeil@yandex-team.ru> wrote:

> In case of bad entries in /proc/mounts just skip cgroup cache initialization.
> Cgroups in output will be shown as "unreachable:cgroup_id".
> 
> Fixes: d5e6ee0dac64 ("ss: introduce cgroup2 cache and helper functions")
> Signed-off-by: Dmitry Yakunin <zeil@yandex-team.ru>
> Reported-by: Donald Sharp <sharpd@nvidia.com>

Applied with one suggestion.
This code has no comments so it is not obvious exactly what it is doing.
Some explanations would help the next person.

      parent reply	other threads:[~2020-10-12  6:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 17:59 [PATCH iproute2] lib: ignore invalid mounts in cg_init_map Dmitry Yakunin
2020-10-08 18:17 ` Donald Sharp
2020-10-12  6:03 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201011230357.198aaa5e@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sharpd@nvidia.com \
    --cc=zeil@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).