From: Stephen Hemminger <stephen@networkplumber.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH v2] lib/color: introduce freely configurable color strings
Date: Mon, 12 Oct 2020 10:04:40 -0700 [thread overview]
Message-ID: <20201012100440.0de0be16@hermes.local> (raw)
In-Reply-To: <20201012164639.20976-1-jengelh@inai.de>
On Mon, 12 Oct 2020 18:46:39 +0200
Jan Engelhardt <jengelh@inai.de> wrote:
> +static struct color_code {
> + const char match[8], *code;
> + int len;
> +} color_codes[C_MAX] = {
> + {"iface="}, {"lladdr="}, {"v4addr="}, {"v6addr="}, {"operup="},
> + {"operdn="}, {"clear=", "0", 1},
> };
Probably better to expand the initializer here to be safe in future.
Also if each match has = that maybe redundant.
static struct color_code {
char match[8], *code;
unsigned int len;
} color_codes[] = {
[C_IFACE] = {
.match = "iface",
},
...
next prev parent reply other threads:[~2020-10-12 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 16:46 [iproute PATCH v2] lib/color: introduce freely configurable color strings Jan Engelhardt
2020-10-12 17:04 ` Stephen Hemminger [this message]
2020-10-12 17:27 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012100440.0de0be16@hermes.local \
--to=stephen@networkplumber.org \
--cc=jengelh@inai.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).